MPP Update #1655
Open
MPP Update #1655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and Reinitialization of segment data on root pe is no longer needed
abrooks1085
requested review from
uramirez8707,
bensonr and
rem1776
as code owners
bensonr
reviewed
Mar 3, 2025
| ! need this check in case MPI-rank 0 is a member of the pelist | ||
| call mpp_max(root_pe_test, pelist) | ||
| if (root_pe_test.lt.0) call mpp_error(FATAL, & | ||
| if ( ANY(pelist(:).eq.mpp_pe()) ) then |
There was a problem hiding this comment.
why is this if-check needed here. We should've kicked out any pe's not in the pelist with the check at line 67.
mpp/include/mpp_util.inc
Outdated
| @@ -870,7 +879,7 @@ end function rarray_to_char | |||
| integer :: SD_UNIT, total_calls | |||
| integer :: j,k,ct, msg_cnt | |||
| character(len=2) :: u | |||
| character(len=FMS_FILE_LEN) :: filename | |||
| character(len=20) :: filename | |||
There was a problem hiding this comment.
Don't we want to continue using FMS_FILE_LEN here?
mpp/include/mpp_util.inc
Outdated
| @@ -1228,7 +1237,7 @@ end function rarray_to_char | |||
| integer, dimension(2) :: lines_and_length | |||
| logical :: file_exist | |||
| character(len=len(peset(current_peset_num)%name)) :: pelist_name | |||
| character(len=FMS_PATH_LEN) :: filename | |||
| character(len=128) :: filename | |||
There was a problem hiding this comment.
Don't we want to continue using FMS_FILE_LEN here?
mpp/include/mpp_util.inc
Outdated
| if ( len_trim(str_tmp) == LENGTH) then | ||
| write(UNIT=text, FMT='(I5)') LENGTH | ||
| if ( len_trim(str_tmp) == LENGTH ) then | ||
| write(UNIT=text, FMT='(I5)') length |
There was a problem hiding this comment.
I know that Fortran does not enforce alphanumeric case, but we should leave this as LENGTH
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates mpp_gather and mpp_scatter routines to use the native collective modes MPI_SCATTER and MPI_GATHER
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note
any relevant details for your test configuration (e.g. compiler, OS). Include
enough information so someone can reproduce your tests.
Checklist:
make distcheckpasses