-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test for collective netcdf mpi io #1647
base: main
Are you sure you want to change the base?
Conversation
. ../test-lib.sh | ||
|
||
if [ ! -z $parallel_skip ]; then | ||
SKIP_TESTS="test_collective_io.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rem1776 thanks for helping me figure this out!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, i think that m4/check_parallel4.c
file can probably be removed though. It should be autogenerated during configure so might have been added accidently.
That is not auto generated. It is used for cmake builds. Lines 292 to 294 in 6fea71e
I wasn't sure about the best way to do this, so let me know if you have a better idea |
The cmake netcdf module should have a check for that already, I think we just weren't using it before: Lines 12 to 18 in eef4a89
We should be able to use that in the conditional instead |
Description
Add a test for collective netcdf mpi io
The test creates a 1 undistributed file io_layout of 1,1 using domain decomposed fms2_io then reads the file using collective netcdf (currently collective netcdf only works if the layout and the io_layout are the same when writing)
Fixes # (issue)
How Has This Been Tested?
CI
Checklist:
make distcheck
passes