Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to filehandler and its associated test #48

Merged
merged 6 commits into from
Feb 20, 2025

Conversation

aerorahul
Copy link
Contributor

@aerorahul aerorahul commented Feb 18, 2025

Description
This PR:

  • adds the ability to link files via FileHandler
  • adds associated test for link.
  • removes older python version tests as they are deprecated in the GH runner.

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • pynorms
  • pytests

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.18%. Comparing base (3ea5acd) to head (f9af333).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #48      +/-   ##
===========================================
+ Coverage    52.79%   53.18%   +0.39%     
===========================================
  Files           18       18              
  Lines         1680     1694      +14     
  Branches       296      300       +4     
===========================================
+ Hits           887      901      +14     
  Misses         743      743              
  Partials        50       50              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: David Huber <69919478+DavidHuber-NOAA@users.noreply.github.com>
…inking files to a directory with the target filename
Copy link
Collaborator

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise I think this is fine

@DavidHuber-NOAA DavidHuber-NOAA merged commit eccb9a5 into develop Feb 20, 2025
17 checks passed
@aerorahul aerorahul deleted the feature/link branch February 20, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants