Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration for the low res marine B #66

Merged
merged 7 commits into from
Feb 3, 2025

Conversation

guillaumevernieres
Copy link
Contributor

description coming soon ...
Resolves part of NOAA-EMC/GDASApp#1375

Copy link
Collaborator

@shlyaeva shlyaeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've mostly reviewed the changes to the ensemble covariances, and looked through the other changes as well; see comments/questions below.
🎉

Copy link
Collaborator

@AndrewEichmann-NOAA AndrewEichmann-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with this, but looks ok

@danholdaway danholdaway added the draft draft PR often used for discussion label Jan 24, 2025
@guillaumevernieres guillaumevernieres merged commit de1fd08 into develop Feb 3, 2025
1 check passed
@guillaumevernieres guillaumevernieres deleted the feature/lowres-b branch February 3, 2025 16:15
guillaumevernieres added a commit to NOAA-EMC/GDASApp that referenced this pull request Feb 4, 2025
As the title says.

## Dependencies
- NOAA-EMC/jcb-gdas#66
- NOAA-EMC/global-workflow#3238
- Update of the static files in glopara:
NOAA-EMC/global-workflow#3239

## Work done in this PR
Interp to low-resolution:
- [ ] variance partitioning
- [ ] preparation of the perturbations for the envar
- [ ] hybrid weights
- [ ] ... 

## Testing
Visual check showing the variance explained by the steric height (30
members)

![steic-explained-variance](https://github.com/user-attachments/assets/274c3fdb-94c3-42fc-ad6e-90867b39a778)
left is native resolution, right is on the 1/2 deg grid.

**"Science" note:** The explained variance above is almost the opposite
to what I would have expected, and what we saw in the previous offline
ensemble, or even what we see in tendencies. Check if there's a bug in
the explained variance calculation.

# Automated CI tests to run in Global Workflow
<!-- Which Global Workflow CI tests are required to adequately test this
PR? -->
- [ ] atm_jjob <!-- JEDI atm single cycle DA !-->
- [ ] C96C48_ufs_hybatmDA <!-- JEDI atm cycled DA !-->
- [ ] C96C48_hybatmaerosnowDA  <!-- JEDI aero/snow cycled DA !-->
- [x] C48mx500_3DVarAOWCDA <!-- JEDI low-res marine 3DVar cycled DA !-->
- [x] C48mx500_hybAOWCDA <!-- JEDI marine hybrid envar cycled DA !-->
- [ ] C96C48_hybatmDA <!-- GSI atm cycled DA !-->
WalterKolczynski-NOAA pushed a commit to NOAA-EMC/global-workflow that referenced this pull request Feb 20, 2025
…3238)

This PR mostly includes configuration changes to allow the use a
B-matrix at a defined resolution that may or may not be the same as the
background.

- Addition of an interpolation step in the B-matrix job
- version update for the fix files
- **the `gdas.cd` update should be the correct one now.**

Resolves #3230 
Resolves NOAA-EMC/GDASApp/issues/1375

# Dependencies
- NOAA-EMC/GDASApp/pull/1441
- NOAA-EMC/jcb-gdas/pull/66

---------

Co-authored-by: Anna Shlyaeva <anna.v.shlyaeva@noaa.gov>
Co-authored-by: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draft draft PR often used for discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants