Eliminate `_gfs`, `_gdas`, etc, variables and add necessary if blocks #3420

AntonMFernando-NOAA · 2025-03-05T22:05:34Z

Description

Following Allow APP to differ between RUNs #2943, it should now be feasible to eliminate most, if not all, variables ending in _RUN from the configuration files and scripts, while incorporating necessary if blocks. These if blocks will trigger errors, serving as an indication that something is significantly wrong. This change will simplify both the resource calculations and the workflow, including the workflow setup scripts.
Resolves Issue Eliminate _gfs _gdas, etc, variables #3000
Refs Allow APP to differ between RUNs #2943

Type of change

Bug fix (fixes something broken)
New feature (adds functionality)
Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

Is this a breaking change (a change in existing functionality)? NO
Does this change require a documentation update? NO
Does this change require an update to any of the following submodules? NO (If YES, please add a link to any PRs that are pending.)
- EMC verif-global
- GDAS
- GFS-utils
- GSI
- GSI-monitor
- GSI-utils
- UFS-utils
- UFS-weather-model
- wxflow

How has this been tested?

…AA/global-workflow into maint/gfs-gdas

github-advanced-security

ShellCheck found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

…AA/global-workflow into maint/gfs-gdas

parm/config/gfs/config.resources

AntonMFernando-NOAA

This is correct?

DavidHuber-NOAA · 2025-03-06T14:15:34Z

parm/config/gefs/config.resources

I think lines 355-364 should be deleted as part of this as well. If all of the _RUN variables are deleted, there should be no need for it.

DavidHuber-NOAA · 2025-03-06T14:17:54Z

parm/config/gefs/config.ufs

+        if [[ "${RUN}" = *gfs ]]; then
+          export layout_x=1
+          export layout_y=1
+          export nthreads_fv3=1
+          export nthreads_ufs=1
+          export WRITE_GROUP=1
+          export WRTTASK_PER_GROUP_PER_THREAD_PER_TILE=1
+        fi
        export layout_x=1
        export layout_y=1
-        export layout_x_gfs=1
-        export layout_y_gfs=1
        export nthreads_fv3=1
-        export nthreads_fv3_gfs=1
        export nthreads_ufs=1
-        export nthreads_ufs_gfs=1


I think you don't need a if block here since the resources are identical for gdas and gfs RUNs.

Suggested change

if [[ "${RUN}" = *gfs ]]; then

export layout_x=1

export layout_y=1

export nthreads_fv3=1

export nthreads_ufs=1

export WRITE_GROUP=1

export WRTTASK_PER_GROUP_PER_THREAD_PER_TILE=1

fi

export layout_x=1

export layout_y=1

export layout_x_gfs=1

export layout_y_gfs=1

export nthreads_fv3=1

export nthreads_fv3_gfs=1

export nthreads_ufs=1

export nthreads_ufs_gfs=1

export layout_x=1

export layout_y=1

export nthreads_fv3=1

export nthreads_ufs=1

export WRITE_GROUP=1

export WRTTASK_PER_GROUP_PER_THREAD_PER_TILE=1

DavidHuber-NOAA · 2025-03-06T14:18:19Z

parm/config/gefs/config.ufs

+        if [[ "${RUN}" = *gfs ]]; then
+          export layout_x=6
+          export layout_y=8
+          export nthreads_fv3=1
+          export nthreads_ufs=1
+          export WRITE_GROUP=1
+          export WRTTASK_PER_GROUP_PER_THREAD_PER_TILE=1
+        fi
        export layout_x=2
        export layout_y=2
-        export layout_x_gfs=6
-        export layout_y_gfs=8
        export nthreads_fv3=1
-        export nthreads_fv3_gfs=1
        export nthreads_ufs=1
-        export nthreads_ufs_gfs=1


Same, no if block needed.

DavidHuber-NOAA · 2025-03-06T14:26:59Z

parm/config/gefs/config.ufs

+        if [[ "${RUN}" = *gfs ]]; then
+          export layout_x=4
+          export layout_y=6
+          export nthreads_fv3=2
+          export nthreads_ufs=2
+          export WRITE_GROUP=2
+          export WRTTASK_PER_GROUP_PER_THREAD_PER_TILE=5
+        fi
        export DELTIM=600
        export layout_x=4
        export layout_y=6
-        export layout_x_gfs=4
-        export layout_y_gfs=6
        export nthreads_fv3=1
-        export nthreads_fv3_gfs=2
        export nthreads_ufs=1
-        export nthreads_ufs_gfs=2


Here, the nthreads_ufs set in the gfs if block is being overridden by the following lines. Suggest either having an if-else block here or declaring defaults first, then overriding with a RUN-based if block:

Suggested change

if [[ "${RUN}" = *gfs ]]; then

export layout_x=4

export layout_y=6

export nthreads_fv3=2

export nthreads_ufs=2

export WRITE_GROUP=2

export WRTTASK_PER_GROUP_PER_THREAD_PER_TILE=5

fi

export DELTIM=600

export layout_x=4

export layout_y=6

export layout_x_gfs=4

export layout_y_gfs=6

export nthreads_fv3=1

export nthreads_fv3_gfs=2

export nthreads_ufs=1

export nthreads_ufs_gfs=2

export DELTIM=600

export layout_x=4

export layout_y=6

export WRITE_GROUP=1

export WRTTASK_PER_GROUP_PER_THREAD_PER_TILE=10

if [[ "${RUN}" = *gfs ]]; then

export nthreads_fv3=2

export nthreads_ufs=2

export WRITE_GROUP=2

export WRTTASK_PER_GROUP_PER_THREAD_PER_TILE=5

fi

Also, lines 151-4 should be deleted.

DavidHuber-NOAA · 2025-03-06T14:27:59Z

parm/config/gefs/config.ufs

+        if [[ "${RUN}" = *gfs ]]; then
+          export layout_x=8
+          export layout_y=8
+          export nthreads_fv3=2
+          export nthreads_ufs=2
+          export WRITE_GROUP=2
+          export WRTTASK_PER_GROUP_PER_THREAD_PER_TILE=10
+        fi
        export DELTIM=300
        export layout_x=6
        export layout_y=8
-        export layout_x_gfs=8
-        export layout_y_gfs=8
        export nthreads_fv3=1
-        export nthreads_fv3_gfs=2
        export nthreads_ufs=1
-        export nthreads_ufs_gfs=2
        export cdmbgwd="1.1,0.72,1.0,1.0"  # mountain blocking, ogwd, cgwd, cgwd src scaling
        export cdmbgwd_gsl="5.0,5.0,1.0,1.0"   # settings for GSL drag suite
        export psl_gwd_dx_factor=6.0


Same as C192.

DavidHuber-NOAA · 2025-03-06T14:28:17Z

parm/config/gefs/config.ufs

+        if [[ "${RUN}" = *gfs ]]; then
+          export layout_x=12
+          export layout_y=16
+          export nthreads_fv3=4
+          export nthreads_ufs=4
+          export WRITE_GROUP=4
+          export WRTTASK_PER_GROUP_PER_THREAD_PER_TILE=20 #Note this should be 10 for WCOSS2
+        fi
        export DELTIM=150
        export layout_x=8
        export layout_y=12
-        export layout_x_gfs=12
-        export layout_y_gfs=16
        export nthreads_fv3=4
-        export nthreads_fv3_gfs=4
        export nthreads_ufs=4
-        export nthreads_ufs_gfs=4
        export cdmbgwd="4.0,0.15,1.0,1.0"  # mountain blocking, ogwd, cgwd, cgwd src scaling
        export cdmbgwd_gsl="2.5,7.5,1.0,1.0"   # settings for GSL drag suite
        export psl_gwd_dx_factor=6.0


Same as C192.

DavidHuber-NOAA · 2025-03-06T14:28:29Z

parm/config/gefs/config.ufs

+        if [[ "${RUN}" = *gfs ]]; then
+          export layout_x=8
+          export layout_y=16
+          export nthreads_fv3=4
+          export nthreads_ufs=4
+          export WRITE_GROUP=4
+          export WRTTASK_PER_GROUP_PER_THREAD_PER_TILE=20 # TODO: refine these numbers when a case is available
+        fi
        export DELTIM=150
        export layout_x=8
        export layout_y=16
-        export layout_x_gfs=8
-        export layout_y_gfs=16
        export nthreads_fv3=4
-        export nthreads_fv3_gfs=4
        export nthreads_ufs=4
-        export nthreads_ufs_gfs=4
        export cdmbgwd="4.0,0.10,1.0,1.0"  # mountain blocking, ogwd, cgwd, cgwd src scaling
        export cdmbgwd_gsl="1.67,8.8,1.0,1.0"   # settings for GSL drag suite


Same as C192.

DavidHuber-NOAA · 2025-03-06T14:31:15Z

parm/config/gfs/config.resources

+    if [[ "${RUN}" = *gdas ]]; then
+      ntasks=5
+      memory="100GB"
+      NTASKS=${ntasks}
+    elif [[ "${RUN}" = *gfs ]]; then
+      ntasks=65
+      memory="150GB"
+      NTASKS=${ntasks}
+    fi


NTASKS could be moved after the if block:

Suggested change

if [[ "${RUN}" = *gdas ]]; then

ntasks=5

memory="100GB"

NTASKS=${ntasks}

elif [[ "${RUN}" = *gfs ]]; then

ntasks=65

memory="150GB"

NTASKS=${ntasks}

fi

if [[ "${RUN}" = *gdas ]]; then

ntasks=5

memory="100GB"

elif [[ "${RUN}" = *gfs ]]; then

ntasks=65

memory="150GB"

fi

NTASKS=${ntasks}

DavidHuber-NOAA · 2025-03-06T14:31:56Z

parm/config/gfs/config.resources

-    memory_gdas="20GB"
-    memory_gfs="20GB"
+    if [[ "${RUN}" = *gdas ]]; then
+      walltime="00:15:00"
+      memory="20GB"
+    elif [[ "${RUN}" = *gfs ]]; then
+      walltime="00:15:00"
+      memory="20GB"
+    fi


Since memory is the same, just declare it once before the if-elif block.

DavidHuber-NOAA · 2025-03-06T14:33:04Z

parm/config/gfs/config.resources

+    if [[ "${RUN}" = *gdas ]]; then
+      ntasks=$(( layout_x * layout_y * 6 ))
+      threads_per_task=1
+      tasks_per_node=$(( max_tasks_per_node / threads_per_task ))
+    elif [[ "${RUN}" = *gfs ]]; then
+      ntasks=$(( layout_x * layout_y * 6 ))
+      threads_per_task=1
+      tasks_per_node=$(( max_tasks_per_node / threads_per_task ))
+    fi


No need for an if-elif block here since the variables are all the same

Suggested change

if [[ "${RUN}" = *gdas ]]; then

ntasks=$(( layout_x * layout_y * 6 ))

threads_per_task=1

tasks_per_node=$(( max_tasks_per_node / threads_per_task ))

elif [[ "${RUN}" = *gfs ]]; then

ntasks=$(( layout_x * layout_y * 6 ))

threads_per_task=1

tasks_per_node=$(( max_tasks_per_node / threads_per_task ))

fi

ntasks=$(( layout_x * layout_y * 6 ))

threads_per_task=1

tasks_per_node=$(( max_tasks_per_node / threads_per_task ))

DavidHuber-NOAA · 2025-03-06T14:33:18Z

parm/config/gfs/config.resources

+    if [[ "${RUN}" = *gdas ]]; then
+      ntasks=$(( layout_x * layout_y * 6 ))
+      threads_per_task=1
+      tasks_per_node=$(( max_tasks_per_node / threads_per_task ))
+    elif [[ "${RUN}" = *gfs ]]; then
+      ntasks=$(( layout_x * layout_y * 6 ))
+      threads_per_task=1
+      tasks_per_node=$(( max_tasks_per_node / threads_per_task ))
+    fi


DavidHuber-NOAA · 2025-03-06T14:35:18Z

parm/config/gfs/config.resources

-    _RUN=${RUN:-"gfs"}
-    _RUN=${RUN/enkf/}
+    RUN_NAME=${RUN:-"gfs"}
+    RUN_NAME=${RUN/enkf/}

-    # Declare variables from config.ufs based on _RUN
+    # Declare variables from config.ufs based on RUN_NAME
    # Export layout and write task variables, but not ntasks/threads
-    # Capitalize _RUN for write tasks
+    # Capitalize RUN_NAME for write tasks
    for var in layout_x layout_y ntasks_fv3 ntasks_quilt nthreads_fv3 nthreads_ufs \
               WRITE_GROUP WRTTASK_PER_GROUP_PER_THREAD; do
      if [[ ${var} =~ "layout" ]]; then
-        ufs_var_name="${var}_${_RUN}"
+        ufs_var_name="${var}_${RUN_NAME}"
        declare -x "${var}"="${!ufs_var_name}"
      elif [[ ${var} =~ "WR" ]]; then
-        ufs_var_name="${var}_${_RUN^^}"
+        ufs_var_name="${var}_${RUN_NAME^^}"
        declare -x "${var}"="${!ufs_var_name}"
      else
-        ufs_var_name="${var}_${_RUN}"
+        ufs_var_name="${var}_${RUN_NAME}"


I don't think this block is required anymore.

DavidHuber-NOAA · 2025-03-06T14:36:41Z

parm/config/gfs/config.resources

-        exit 4
-        ;;
-    esac
+    if [[ "${RUN}" =~ gdas ]]; then


This if will capture both gdas and enkfgdas.

Should just be == gdas.

DavidHuber-NOAA · 2025-03-06T14:38:40Z

parm/config/gfs/config.resources

+    elif [[ "${RUN}" =~ enkfgdas ]]; then
+      case "${CASE}" in
+        "C48" | "C96" | "C192")
+          declare -x "walltime"="00:20:00"
+          ;;
+        "C384")
+          declare -x "walltime"="00:30:00"
+          ;;
+        *)
+          echo "FATAL ERROR: Resources not defined for job ${step} at resolution ${CASE}"
+          exit 4
+          ;;
+      esac


The enkfgdas and enkfgfs if blocks can be combined.

DavidHuber-NOAA · 2025-03-06T14:38:58Z

parm/config/gfs/config.resources


-    unset _RUN
+    unset RUN_NAME


Suggested change

unset RUN_NAME

DavidHuber-NOAA · 2025-03-06T14:40:02Z

parm/config/gfs/config.resources.HERA

-      export ntasks_gdas=270
-      export ntasks_gfs=270
+    if [[ "${RUN}" = *gdas ]]; then
+      export ntasks=270
+    elif [[ "${RUN}" = *gfs ]]; then
+      export ntasks=270
+    fi


Just ntasks=270 should suffice.

DavidHuber-NOAA · 2025-03-06T14:40:15Z

parm/config/gfs/config.resources.HERA

+    if [[ "${RUN}" = *gdas ]]; then
+      export tasks_per_node=12
+    elif [[ "${RUN}" = *gfs ]]; then
+      export tasks_per_node=12
+    fi


DavidHuber-NOAA · 2025-03-06T14:40:26Z

parm/config/gfs/config.resources.HERCULES

+    if [[ "${RUN}" = *gdas ]]; then
+      export tasks_per_node=48
+    elif [[ "${RUN}" = *gfs ]]; then
+      export tasks_per_node=48
+    fi


DavidHuber-NOAA · 2025-03-06T14:40:40Z

parm/config/gfs/config.resources.ORION

+    if [[ "${RUN}" = *gdas ]]; then
+      export tasks_per_node=8
+    elif [[ "${RUN}" = *gfs ]]; then
+      export tasks_per_node=8
+    fi


DavidHuber-NOAA · 2025-03-06T14:49:24Z

parm/config/gfs/config.resources.S4

+          if [[ "${RUN}" = *gdas ]]; then
+            export ntasks=416
+          elif [[ "${RUN}" = *gfs ]]; then
+            export ntasks=416
+          fi
        fi
        #S4 is small, so run this task with just 1 thread
        export threads_per_task=1
-        export walltime_gdas="02:00:00"
-        export walltime_gfs="02:00:00"
+        if [[ "${RUN}" = *gdas ]]; then
+          export walltime="02:00:00"
+        elif [[ "${RUN}" = *gfs ]]; then
+          export walltime="02:00:00"
+        fi
        ;;
      "C192" | "C96" | "C48")
        export threads_per_task=4
        if [[ ${PARTITION_BATCH} == "s4" ]]; then
-          export ntasks_gdas=88
-          export ntasks_gfs=88
+          if [[ "${RUN}" = *gdas ]]; then
+            export ntasks=88
+          elif [[ "${RUN}" = *gfs ]]; then
+            export ntasks=88
+          fi
        elif [[ ${PARTITION_BATCH} == "ivy" ]]; then
-          export ntasks_gdas=90
-          export ntasks_gfs=90
+          if [[ "${RUN}" = *gdas ]]; then


DavidHuber-NOAA · 2025-03-06T14:49:36Z

parm/config/gfs/config.resources.WCOSS2

+    if [[ "${RUN}" = *gdas ]]; then
+      export tasks_per_node=48
+    elif [[ "${RUN}" = *gfs ]]; then
+      export tasks_per_node=48
+    fi


DavidHuber-NOAA · 2025-03-06T14:50:06Z

parm/config/gfs/config.ufs

See comments on the GEFS config.ufs.

parm/config/gfs/config.resources.S4

DavidHuber-NOAA · 2025-03-07T20:09:27Z

parm/config/gefs/config.ufs

+        if [[ "${RUN}" = *gfs ]]; then
+          export layout_x=6
+          export layout_y=8
+        fi


Actually, this shouldn't be needed in GEFS since the only RUN is gefs.

Suggested change

if [[ "${RUN}" = *gfs ]]; then

export layout_x=6

export layout_y=8

fi

DavidHuber-NOAA · 2025-03-07T20:12:28Z

parm/config/gfs/config.resources.HERA

+    export ntasks=270
+    export threads_per_task=8
+    export tasks_per_node=$(( max_tasks_per_node / threads_per_task ))


Indents:

Suggested change

export ntasks=270

export threads_per_task=8

export tasks_per_node=$(( max_tasks_per_node / threads_per_task ))

export ntasks=270

export threads_per_task=8

export tasks_per_node=$(( max_tasks_per_node / threads_per_task ))

DavidHuber-NOAA · 2025-03-07T20:14:24Z

parm/config/gfs/config.ufs

+        if [[ "${RUN}" = *gdas ]]; then
+          export layout_x=1
+          export layout_y=1
+          export nthreads_fv3=1
+          export nthreads_ufs=1
+          export WRITE_GROUP=1
+          export WRTTASK_PER_GROUP_PER_THREAD_PER_TILE=1
+        elif [[ "${RUN}" = *gfs ]]; then
+          export layout_x=1
+          export layout_y=1
+          export nthreads_fv3=1
+          export nthreads_ufs=1
+          export WRITE_GROUP=1
+          export WRTTASK_PER_GROUP_PER_THREAD_PER_TILE=1
+        fi


Since these are identical, there's no need for an if-else:

Suggested change

if [[ "${RUN}" = *gdas ]]; then

export layout_x=1

export layout_y=1

export nthreads_fv3=1

export nthreads_ufs=1

export WRITE_GROUP=1

export WRTTASK_PER_GROUP_PER_THREAD_PER_TILE=1

elif [[ "${RUN}" = *gfs ]]; then

export layout_x=1

export layout_y=1

export nthreads_fv3=1

export nthreads_ufs=1

export WRITE_GROUP=1

export WRTTASK_PER_GROUP_PER_THREAD_PER_TILE=1

fi

export layout_x=1

export layout_y=1

export nthreads_fv3=1

export nthreads_ufs=1

export WRITE_GROUP=1

export WRTTASK_PER_GROUP_PER_THREAD_PER_TILE=1

parm/config/gfs/config.ufs

DavidHuber-NOAA · 2025-03-07T20:16:44Z

parm/config/gfs/config.ufs

+          if [[ "${RUN}" = *gdas ]]; then
+            export nthreads_fv3=1
+            export nthreads_ufs=1
+            export layout_x=2
+            export layout_y=2
+            export WRITE_GROUP=1
+            export WRTTASK_PER_GROUP_PER_THREAD_PER_TILE=1
+          elif [[ "${RUN}" = *gfs ]]; then
+            export nthreads_fv3=1
+            export nthreads_ufs=1
+            export layout_x=2
+            export layout_y=2
+            export WRITE_GROUP=1
+            export WRTTASK_PER_GROUP_PER_THREAD_PER_TILE=1
+          fi


Since these are the same, there's no need for an if-elif block:

Suggested change

if [[ "${RUN}" = *gdas ]]; then

export nthreads_fv3=1

export nthreads_ufs=1

export layout_x=2

export layout_y=2

export WRITE_GROUP=1

export WRTTASK_PER_GROUP_PER_THREAD_PER_TILE=1

elif [[ "${RUN}" = *gfs ]]; then

export nthreads_fv3=1

export nthreads_ufs=1

export layout_x=2

export layout_y=2

export WRITE_GROUP=1

export WRTTASK_PER_GROUP_PER_THREAD_PER_TILE=1

fi

export nthreads_fv3=1

export nthreads_ufs=1

export layout_x=2

export layout_y=2

export WRITE_GROUP=1

export WRTTASK_PER_GROUP_PER_THREAD_PER_TILE=1

DavidHuber-NOAA · 2025-03-07T20:21:15Z

parm/config/gfs/config.ufs

        ;;
    "C96")
        if [[ "${DO_NEST:-NO}" == "YES" ]] ; then
+          if [[ "${RUN}" = *gdas ]]; then


@aerorahul I am unsure of how nesting works. Should there be gdas, gfs, and nest grids, threading, write tasks, etc? Or only gfs and nest?

I am not sure either. For now, let us assume that DO_NEST is only ON for RUN=gdas. It is possible that nesting will not be supported going forward as that project is looking elsewhere.

DavidHuber-NOAA · 2025-03-07T20:23:13Z

parm/config/gfs/config.ufs

+          if [[ "${RUN}" = *gdas ]]; then
+            export layout_x=4
+            export layout_y=6
+            export nthreads_fv3=1
+            export nthreads_ufs=1
+            export WRITE_GROUP=1
+            export WRTTASK_PER_GROUP_PER_THREAD_PER_TILE=10
+          elif [[ "${RUN}" = *gfs ]]; then
+            export layout_x=4
+            export layout_y=6
+            export nthreads_fv3=2
+            export nthreads_ufs=2
+            export WRITE_GROUP=2
+            export WRTTASK_PER_GROUP_PER_THREAD_PER_TILE=5
+          fi


Since the layouts are the same for gdas and gfs RUNs, they could be pulled out of the if-elif block:

Suggested change

if [[ "${RUN}" = *gdas ]]; then

export layout_x=4

export layout_y=6

export nthreads_fv3=1

export nthreads_ufs=1

export WRITE_GROUP=1

export WRTTASK_PER_GROUP_PER_THREAD_PER_TILE=10

elif [[ "${RUN}" = *gfs ]]; then

export layout_x=4

export layout_y=6

export nthreads_fv3=2

export nthreads_ufs=2

export WRITE_GROUP=2

export WRTTASK_PER_GROUP_PER_THREAD_PER_TILE=5

fi

export layout_x=4

export layout_y=6

if [[ "${RUN}" = *gdas ]]; then

export nthreads_fv3=1

export nthreads_ufs=1

export WRITE_GROUP=1

export WRTTASK_PER_GROUP_PER_THREAD_PER_TILE=10

elif [[ "${RUN}" = *gfs ]]; then

export nthreads_fv3=2

export nthreads_ufs=2

export WRITE_GROUP=2

export WRTTASK_PER_GROUP_PER_THREAD_PER_TILE=5

fi

DavidHuber-NOAA · 2025-03-07T20:24:35Z

parm/config/gfs/config.ufs

+          if [[ "${RUN}" = *gdas ]]; then
+            export layout_x=8
+            export layout_y=8
+            export nthreads_fv3=2
+            export nthreads_ufs=2
+            export WRITE_GROUP=4
+            export WRTTASK_PER_GROUP_PER_THREAD_PER_TILE=10
+          elif [[ "${RUN}" = *gfs ]]; then
+            export layout_x=8
+            export layout_y=8
+            export nthreads_fv3=2
+            export nthreads_ufs=2
+            export WRITE_GROUP=4
+            export WRTTASK_PER_GROUP_PER_THREAD_PER_TILE=10
+          fi


No need for an if-elif block since all of the parameters are the same.

DavidHuber-NOAA · 2025-03-07T20:24:59Z

parm/config/gfs/config.ufs

+          if [[ "${RUN}" = *gdas ]]; then
+            export layout_x=16
+            export layout_y=10
+            export nthreads_fv3=2
+            export WRITE_GROUP=2
+            export WRTTASK_PER_GROUP_PER_THREAD_PER_TILE=90
+          elif [[ "${RUN}" = *gfs ]]; then
+            export layout_x=16
+            export layout_y=10
+            export nthreads_fv3=2
+            export WRITE_GROUP=2
+            export WRTTASK_PER_GROUP_PER_THREAD_PER_TILE=90
+          fi


AntonMFernando-NOAA and others added 10 commits March 5, 2025 11:48

modified parm\config\gfs\config.resources

45c6a60

Merge branch 'maint/gfs-gdas' of https://github.com/AntonMFernando-NO…

1735dad

…AA/global-workflow into maint/gfs-gdas

Merge branch 'maint/gfs-gdas' of https://github.com/AntonMFernando-NO…

644656b

…AA/global-workflow into maint/gfs-gdas

modify parm\config\gfs\config.resources

0942065

modified config. ufs and resourses gefs/gfs

a19e5df

modified parm\config\gfs\config.resources.WCOSS2

69e8716

modified parm\config\sfs\config.resources

7786b94

modified parm\config\gfs\config.resources.HERA

6863d95

modified resources files Orion/Hercules/S4

1ce3286

Merge branch 'develop' into maint/gfs-gdas

b52f5b0

github-advanced-security bot found potential problems Mar 5, 2025

View reviewed changes

AntonMFernando-NOAA added 2 commits March 5, 2025 18:13

modified =~ *

dbe0b92

Merge branch 'maint/gfs-gdas' of https://github.com/AntonMFernando-NO…

e469c4e

…AA/global-workflow into maint/gfs-gdas

github-advanced-security bot found potential problems Mar 5, 2025

View reviewed changes

parm/config/gfs/config.resources Fixed Show fixed Hide fixed

remove a comment # That is, RUN=gdas or RUN=enkfgdas

5ceb333

AntonMFernando-NOAA commented Mar 5, 2025

View reviewed changes

modified parm\config\gfs\config.resources

7ed33c1

AntonMFernando-NOAA changed the title ~~Eliminate _gfs, _gdas, etc, variables and replace them with if blocks~~ Eliminate _gfs, _gdas, etc, variables and add necessary if blocks Mar 6, 2025

Merge branch 'develop' into maint/gfs-gdas

84469f0

DavidHuber-NOAA reviewed Mar 6, 2025

View reviewed changes

parm/config/gfs/config.resources Outdated

unset _RUN

unset RUN_NAME

Copy link

Contributor

DavidHuber-NOAA Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

unset RUN_NAME

DavidHuber-NOAA reviewed Mar 6, 2025

View reviewed changes

parm/config/gfs/config.ufs

Copy link

Contributor

DavidHuber-NOAA Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments on the GEFS config.ufs.

Merge branch 'develop' into maint/gfs-gdas

83ac305

AntonMFernando-NOAA self-assigned this Mar 6, 2025

AntonMFernando-NOAA added 4 commits March 6, 2025 12:09

Huber suggestions

55bd4e6

modified parm\config\gfs\config.resources

b1107c5

modified parm\config\gfs\config.resources

e37b958

modified parm\config\gfs\config.resources.S4

781c8d0

github-advanced-security bot found potential problems Mar 6, 2025

View reviewed changes

parm/config/gfs/config.resources.S4 Fixed Show fixed Hide fixed

modified parm\config\gfs\config.resources.S4

f02197f

DavidHuber-NOAA reviewed Mar 7, 2025

View reviewed changes

parm/config/gfs/config.ufs Show resolved Hide resolved

DavidHuber-NOAA reviewed Mar 7, 2025

View reviewed changes

DavidHuber-NOAA requested changes Mar 7, 2025

View reviewed changes

Huber changes

200e8f0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Eliminate `_gfs`, `_gdas`, etc, variables and add necessary if blocks #3420

Eliminate `_gfs`, `_gdas`, etc, variables and add necessary if blocks #3420

AntonMFernando-NOAA commented Mar 5, 2025

github-advanced-security bot left a comment

AntonMFernando-NOAA left a comment •

edited

Loading

DavidHuber-NOAA Mar 6, 2025

DavidHuber-NOAA Mar 6, 2025

DavidHuber-NOAA Mar 6, 2025

DavidHuber-NOAA Mar 6, 2025

DavidHuber-NOAA Mar 6, 2025

DavidHuber-NOAA Mar 6, 2025

DavidHuber-NOAA Mar 6, 2025

DavidHuber-NOAA Mar 6, 2025

DavidHuber-NOAA Mar 6, 2025

DavidHuber-NOAA Mar 6, 2025

DavidHuber-NOAA Mar 6, 2025

DavidHuber-NOAA Mar 6, 2025

DavidHuber-NOAA Mar 6, 2025

DavidHuber-NOAA Mar 6, 2025

DavidHuber-NOAA Mar 6, 2025

DavidHuber-NOAA Mar 6, 2025

DavidHuber-NOAA Mar 6, 2025

DavidHuber-NOAA Mar 6, 2025

DavidHuber-NOAA Mar 6, 2025

DavidHuber-NOAA Mar 6, 2025

DavidHuber-NOAA Mar 6, 2025

DavidHuber-NOAA Mar 6, 2025

DavidHuber-NOAA Mar 6, 2025

DavidHuber-NOAA Mar 7, 2025

DavidHuber-NOAA Mar 7, 2025

DavidHuber-NOAA Mar 7, 2025

DavidHuber-NOAA Mar 7, 2025

DavidHuber-NOAA Mar 7, 2025

aerorahul Mar 7, 2025

DavidHuber-NOAA Mar 7, 2025

DavidHuber-NOAA Mar 7, 2025

DavidHuber-NOAA Mar 7, 2025

Eliminate _gfs, _gdas, etc, variables and add necessary if blocks #3420

Are you sure you want to change the base?

Eliminate _gfs, _gdas, etc, variables and add necessary if blocks #3420

Conversation

AntonMFernando-NOAA commented Mar 5, 2025

Description

Type of change

Change characteristics

How has this been tested?

github-advanced-security bot left a comment

Choose a reason for hiding this comment

AntonMFernando-NOAA left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Eliminate `_gfs`, `_gdas`, etc, variables and add necessary if blocks #3420

Eliminate `_gfs`, `_gdas`, etc, variables and add necessary if blocks #3420

AntonMFernando-NOAA left a comment •

edited

Loading