-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the eomg job #3331
base: develop
Are you sure you want to change the base?
Remove the eomg job #3331
Conversation
@WalterKolczynski-NOAA @DavidHuber-NOAA @aerorahul : this PR is ready for review. There are some differences between the baseline output and the updated code output, which is unexpected. @DavidHuber-NOAA has suggested we go ahead with this PR and then rerun the test once approvals are made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the comments, there are some additional places where eomg
needs to be removed. Specifically:
parm/config/gfs/config.resources*
parm/config/gfs/config.eobs (this config was used by eomg and there are a couple of eomg-specific variables)
parm/archive/enkf.yaml.j2
Also, there is still a mention of eomg
in gfs_tasks.py (under the eupd
method).
Also, there are some checks for parm/archive/enkf_restarta_grp.yaml.j2 |
@DavidGrumm-NOAA Per our discussion, please just remove parm/config/gfs/config.anal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks pretty good. I just have a couple of suggestions on the namelists since we cannot control the default values of lobsdiag_forenkf
and one other place in the setup scripts that needs the flag removed.
fi | ||
fi | ||
mkdir -p "${COMOUT_ATMOS_ANALYSIS_MEM}" | ||
mkdir -p "${COM_ATMOS_ANALYSIS_MEM}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is supposed to be COMOUT_ATMOS_ANALYSIS_MEM
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DavidGrumm-NOAA It looks like this still needs to be fixed. This caused a failure in the eupd job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small change remaining. After that, I think CI tests can be started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me.
Experiment C96C48_hybatmDA FAILED on Hera in Build# 1 with error logs:
Follow link here to view the contents of the above file(s): (link) |
Experiment C48mx500_hybAOWCDA FAILED on Hera in Build# 1 with error logs:
Follow link here to view the contents of the above file(s): (link) |
Experiment C96C48_hybatmaerosnowDA FAILED on Hera in Build# 1 with error logs:
Follow link here to view the contents of the above file(s): (link) |
Experiment C96C48_hybatmDA FAILED on Hera in Build# 1 in |
Experiment C96C48_hybatmaerosnowDA FAILED on Hera in Build# 1 in |
Experiment C48mx500_hybAOWCDA FAILED on Hera in Build# 1 in |
Experiment C96_atm3DVar FAILED on Hera in Build# 1 with error logs:
Follow link here to view the contents of the above file(s): (link) |
Experiment C96_atm3DVar FAILED on Hera in Build# 1 in |
Experiment C48mx500_3DVarAOWCDA FAILED on Hera in Build# 1 with error logs:
Follow link here to view the contents of the above file(s): (link) |
Experiment C48mx500_3DVarAOWCDA FAILED on Hera in Build# 1 in |
Experiment C96C48_ufs_hybatmDA FAILED on Hera in Build# 1 with error logs:
Follow link here to view the contents of the above file(s): (link) |
Experiment C96C48_ufs_hybatmDA FAILED on Hera in Build# 1 in |
@DavidGrumm-NOAA In addition to the eupd job failure, it looks like the verfrad job is failing. Can you take a look at the log an try to determine the issue: |
CI Failed on Hera in Build# 1
|
WCOSS2 g-w CI Install
Several of the DA cases encountered failures
|
lobsdiag_forenkf=${lobsdiag_forenkf}, | ||
lobsdiag_forenkf=.true., |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On inspection, this should be reverted:
lobsdiag_forenkf=${lobsdiag_forenkf}, | |
lobsdiag_forenkf=.true., | |
lobsdiag_forenkf=${lobsdiag_forenkf} |
@@ -56,7 +56,6 @@ cao_check=${cao_check:-".true."} | |||
ta2tb=${ta2tb:-".true."} | |||
|
|||
# Diagnostic files options | |||
lobsdiag_forenkf=${lobsdiag_forenkf:-".false."} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here:
lobsdiag_forenkf=${lobsdiag_forenkf:-".false."} | |
lobsdiag_forenkf=${lobsdiag_forenkf:-".false."} |
@@ -24,7 +21,4 @@ fi | |||
export USE_RADSTAT="NO" # This can be only used when bias correction is non-zero. | |||
export GENDIAG="YES" # Diagnostic files must be created for EnKF | |||
|
|||
export lobsdiag_forenkf=".true." # write out jacobians from eobs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here as well:
export lobsdiag_forenkf=".true." # write out jacobians from eobs | |
export lobsdiag_forenkf=".true." # write out jacobians from eobs | |
# need to specify .true. setting since config.anal sets to .false. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@@ -25,10 +25,6 @@ if [[ ${LEVS} = "128" ]]; then | |||
export SETUP="gpstop=55,nsig_ext=45,${SETUP:-}" | |||
fi | |||
|
|||
# Set namelist option for LETKF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And lastly here:
# Set namelist option for LETKF | |
# Set namelist option for LETKF | |
export lobsdiag_forenkf=".false." # anal does not need to write out jacobians | |
# set to .true. in config.eobs and config.eupd | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Description
The eomg job is no longer supported for the GSI and the GDASApp has its own jobs to handle observational diagnostics (i.e. when lobsdiag=".true."): atmensanlobs and atmensanlsol. Thus, the eomg job will be removed from the global workflow without affecting the new atmensanlobs and atmensanlsol jobs.
This PR resolves issue #2525.
Type of change
Change characteristics
How has this been tested?
Checklist