Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename generate_com to declare_from_tmpl #2453

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Rename generate_com to declare_from_tmpl #2453

merged 1 commit into from
Apr 4, 2024

Conversation

WalterKolczynski-NOAA
Copy link
Contributor

Description

The generate_com function is renamed to declare_from_tmpl. NCO requested the change, and the new name more accurately represents the functionality.

Resolves #2344

Type of change

  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

  • Cycled test on Orion

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

@WalterKolczynski-NOAA
Rename generate_com to declare_from_tmpl
5129342 
The `generate_com` function is renamed to `declare_from_tmpl`. NCO
requested the change, and the new name more accurately represents
the functionality.

Resovles NOAA-EMC#2344
KateFriedman-NOAA
KateFriedman-NOAA approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for renaming this @WalterKolczynski-NOAA !

@WalterKolczynski-NOAA WalterKolczynski-NOAA added the CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion label Apr 3, 2024
@emcbot emcbot added CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress and removed CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress labels Apr 3, 2024
@emcbot
Copy link

emcbot commented Apr 3, 2024

CI SUCCESS Orion at 04 03 18:51:17

Built and ran in directory /work2/noaa/stmp/CI/ORION/2453

@emcbot emcbot added the CI-Orion-Passed **Bot use only** CI testing on Orion for this PR has completed successfully label Apr 3, 2024
aerorahul
aerorahul approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@aerorahul aerorahul merged commit 108ce2a into NOAA-EMC:develop Apr 4, 2024
9 checks passed
@WalterKolczynski-NOAA WalterKolczynski-NOAA deleted the feature/rename_generate_com branch April 4, 2024 20:47
@AndrewEichmann-NOAA AndrewEichmann-NOAA mentioned this pull request Apr 5, 2024
Closed
danholdaway added a commit to danholdaway/global-workflow that referenced this pull request Apr 8, 2024
@danholdaway
Merge remote-tracking branch 'upstream/develop' into feature/use_jcb_atm
c3d43b9 
* upstream/develop:
  Flip the build for GFS and GEFS with waves (NOAA-EMC#2462)
  Add new data sources used in GFS v16.3.12 (NOAA-EMC#2283)
  The soca fix path is needed in config.prepoceanobs (NOAA-EMC#2460)
  Turn off reducedgrid in the EnKF (NOAA-EMC#2456)
  Rename generate_com to declare_from_tmpl (NOAA-EMC#2453)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aerorahul aerorahul aerorahul approved these changes

@KateFriedman-NOAA KateFriedman-NOAA KateFriedman-NOAA approved these changes

Assignees
No one assigned
Labels
CI-Orion-Passed **Bot use only** CI testing on Orion for this PR has completed successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename generate_com
4 participants
@WalterKolczynski-NOAA @emcbot @aerorahul @KateFriedman-NOAA