Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename wave files to standardized form #3270

Open
2 tasks
WalterKolczynski-NOAA opened this issue Jan 27, 2025 · 0 comments · May be fixed by #3406
Open
2 tasks

Rename wave files to standardized form #3270

WalterKolczynski-NOAA opened this issue Jan 27, 2025 · 0 comments · May be fixed by #3406
Assignees
Milestone

Comments

@WalterKolczynski-NOAA
Copy link
Contributor

WalterKolczynski-NOAA commented Jan 27, 2025

What new functionality do you need?

All intermediate and final wave output should be standardized according to proposed format.

What are the requirements for the new functionality?

All wave output should use the standardized format RUN.wave.tHHz.product[.domain][.fHHH].suffix, as per the COM inventory spreadsheet.

Acceptance Criteria

  • All wave output matches the new filenames in the COM inventory spreadsheet
  • Other than filenames, wave output is identical to before

Suggest a solution (optional)

No response

@WalterKolczynski-NOAA WalterKolczynski-NOAA added feature New feature or request triage Issues that are triage labels Jan 27, 2025
@WalterKolczynski-NOAA WalterKolczynski-NOAA self-assigned this Jan 27, 2025
@WalterKolczynski-NOAA WalterKolczynski-NOAA removed the triage Issues that are triage label Jan 27, 2025
@WalterKolczynski-NOAA WalterKolczynski-NOAA added this to the GFS v17 milestone Jan 27, 2025
@WalterKolczynski-NOAA WalterKolczynski-NOAA removed the feature New feature or request label Feb 24, 2025
WalterKolczynski-NOAA added a commit to WalterKolczynski-NOAA/global-workflow that referenced this issue Feb 25, 2025
Wave products are renamed to be uniform with other components and
follow NCO implementation standards. This means all output is in
the format `${RUN}.wave.tCCz.product[.fHHH][.domain].suffix`.

Some wave scripts (init and gridded post) are refactored to make
them consistent with other parts of the workflow. All scripts for
both jobs now pass `shellcheck` without warnings.

The biggest changes in the refactor include beyond those necessary
for the file rename include:
- Using the `run_mpmd.sh` script
- Updated templates to use atparse instead of `sed`
- Removed redirection of output to logs that get deleted (NOAA-EMC#296)

One functional change is raw interpolated grids are no longer
copied to COM, only the resulting grib files. Need to confirm with
Jessica this is okay.

Refs NOAA-EMC#296
Refs NOAA-EMC#3270
@WalterKolczynski-NOAA WalterKolczynski-NOAA linked a pull request Feb 27, 2025 that will close this issue
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants