-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gfs_bufr using the lastest version with bugzilla fix #19
Conversation
src/gfs_bufr.fd/meteorg.f
Outdated
@@ -6,35 +6,36 @@ subroutine meteorg(npoint,rlat,rlon,istat,cstat,elevstn, | |||
|
|||
!$$$ SUBPROGRAM DOCUMENTATION BLOCK | |||
! . . . . | |||
! SUBPROGRAM: meteorg | |||
! SUBPROGRAM: meteorg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you clean out all of the extra whitespace that was added throughout this code? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, please check the latest commit. @KateFriedman-NOAA @HuiyaChuang-NOAA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better, just one last extra whitespace at the end of line 1108 in src/gfs_bufr.fd/meteorg.f
. Thanks for cleaning those out, it makes it cleaner and easier to see the actual code changes now. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KateFriedman-NOAA done.
@BoCui-NOAA Please open an issue in gfs-utils to link this PR to. Within the issue's main comment please include details of what is getting updated and why. Thanks! |
@KateFriedman-NOAA I opened an issue in gfs-utils, will clean out the extra white space in the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine to me.
I don't know how to test this, so assuming these are tested by the devs.
@BoCui-NOAA I ran the gfspostsnd job within the global-workflow twice...1) first with the existing gfs_utils repo execs (e.g. existing gfs_bufr) as they are in our Run 1:
Run 2:
|
@KateFriedman-NOAA I compared the output files on Orion. The records are identical from the two runs. No issue was found. Thanks for running the tests. |
Thanks for checking the outputs @BoCui-NOAA ! I will proceed with approving this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates look good, thanks for sending them into the gfs-utils repo @BoCui-NOAA !
Update gfs_bufr.fd using the latest version of gfs-v16.
fix global-workflow issue NOAA-EMC/global-workflow#1245