Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore checksum option and performance with (1,1) io layout #556

Merged
merged 4 commits into from
Jun 29, 2022

Conversation

junwang-noaa
Copy link
Collaborator

Description

The PR includes code changes related to dycore NOAA-GFDL/GFDL_atmos_cubed_sphere#197. In PR#197, an option is added to allow one to override restart data integrity checks enforced for FMS-based io, also the PR has enhancements to improve new FMS-based io when using an io_layout of (1,1)

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

Testing

How were these changes tested?
The code changes have been tested in global, regional and hafs applications.
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?

  • Yes, on hera.

Dependencies

…_layout=1,1 and allow one to override data integrity checks in FMS restart logic
@jkbk2004
Copy link
Collaborator

@BinLiu-NOAA @EricRogers-NOAA ufs-wm RT tests were done for this PR thru PR 1294. We can start merging process for this PR with your final comments

@DusanJovic-NOAA DusanJovic-NOAA changed the title ignore checksum option and performance with (1,1) io layout Ignore checksum option and performance with (1,1) io layout Jun 29, 2022
@DusanJovic-NOAA DusanJovic-NOAA merged commit 18bf9b7 into NOAA-EMC:develop Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants