-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a README #313
Add a README #313
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is great to add documentation but I am confused by the statement "This is the [NOAA Environmental Modeling Center] version of the FV3 atmospheric model dynamical core" because this repository sits above the FV3 dycore and the physics. I suggest generalizing this statement.
@ligiabernardet yes please. What should it say instead? |
@edwardhartnett It will take someone with more knowledge than me about FV3ATM to write a complete statement. But here is a starting point: |
stochastic physics are not part of fv3atm, they are part of the ufs-weather-model. fv3atm only contains wrapper code to call stochastic physics. The only submodules are ccpp-frramework, ccpp-physics, GFDL_atmos_cubed_sphere. |
Thanks, I have updated based on your comments. Take another look at see what you think. What shall we say about the io and the cpl components? |
They are part of fv3atm, i.e. part of the infrastructure that connects all the bits and pieces ... not sure how you want to word this. |
Are there any papers, posters or presentations about this repo? |
I am not aware of papers, posters or presentations about this repo. Thank you for the changes. |
OK, I believe this is ready to merge. I need someone to approve the code review... |
If there are no more comments, @junwang-noaa can you approve this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The readme looks good to me. It can be commit it after current PR.
@edwardhartnett Ed, it looks to me you need to sync your branch with the top of develop branch? We can't merge the PR until your branch is updated. |
I have merged the latest develop branch of fv3atm with branch. @junwang-noaa sorry it took so long, but I didn't notice. ;-) There is a setting that can be turned on to allow code maintainers to do these merges to branches from forks - we do this with the NCEPLIBS repos. Then this kind of update can be done without involving others, and so can happen a lot more quickly. In a rapidly changing repo, this makes a big difference and saves this kind of waiting... |
Ed, would you mind us combine your PR with Dusan's PR#330 (planned for tomorrow)? We have several FV3 PRs in the queue. Thanks |
@junwang-noaa merge this in whatever way is convenient for you. Let me know if you need me to do anything further. |
Fixes #312
Comments and additions welcome.
I'm sure my description of fv3atm in the first paragraph can be improved - what should it say?
Are there any conference papers or posters we can provide references to?