Issue #998 - coupling update error fix #999
Conversation
|
@ukmo-juan-castillo, thank you for this fix for coupling exchange check. I'll start the regression tests. |
|
@ukmo-juan-castillo, could you please sync your branch to bring it current with develop? |
|
Thank you for syncing @ukmo-juan-castillo. |
There was a problem hiding this comment.
Code review Pass
Regtests Pass
The only non-identicals are the known non-b4b's.
**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR1_MPI_e (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2 (18 files differ)
mww3_test_03/./work_PR1_MPI_d2 (10 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c (17 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2 (20 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2 (16 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2 (16 files differ)
ww3_tp2.10/./work_MPI_OMPH (7 files differ)
ww3_tp2.16/./work_MPI_OMPH (4 files differ)
ww3_ufs1.3/./work_a (3 files differ)
**********************************************************************
************************ identical cases *****************************
**********************************************************************
matrixCompSummary.txt
matrixCompFull.txt
matrixDiff.txt
This is OK to proceed from the EMC side. I'll give some time today for @ukmo-ccbunney @mickaelaccensi to comment since it deals with OASIS coupling.
There was a problem hiding this comment.
Changes look good to me @ukmo-juan-castillo. It's great that this has also simplified and cleaned up the code of the bugfix from the other issue too - double win!
Results of the the OASIS coupling regtests are all looking fine.
Great! Thank you for your review @ukmo-ccbunney. |
There was a problem hiding this comment.
This has previously been reviewed (#999 (review)), and passed both the code review and regtests. @ukmo-ccbunney has given the OK with respect to the OASIS coupling (#999 (review)).
Approved.
|
@ukmo-juan-castillo, Thank you for providing this fix that addresses #998, as well as #816! Excellent work! |
* Backport of coupling update error fix from develop. See: NOAA-EMC#999 * Fixed typo
* origin/develop: handle NaN air-sea temperatures from nearest land points (NOAA-EMC#869) Increase valid_max for f in ounp (NOAA-EMC#1014) Bugfix deallocation of invalid memory in ww3_prnc (NOAA-EMC#1016) Update to orion intel module path and two typo corrections. (NOAA-EMC#1011) Bugfix to out of bounds array write in w3profsmd_pdlib.f90 (NOAA-EMC#1013) Simple logic fix for time interpolation of boundary nodes at the end of W3XYPFSNIMP. (NOAA-EMC#1005) in w3iors use NSEA instead of NSEAL in serial write/read of VA (NOAA-EMC#954) Update documentation for UNST namelist (NOAA-EMC#986) In certain coupled configurations, the piece of code testing the coupling frequency to check if 'receive' coupling exchanges need to take place fail, resulting in an infinite loop causing the integration between time zero and the first time step to repeat indefinitely. This check needs to be rewritten, which fixes also issue NOAA-EMC#816 in a simpler way. (NOAA-EMC#999)
Pull Request Summary
In certain coupled configurations, the piece of code testing the coupling frequency to check if 'receive' coupling exchanges need to take place fail, resulting in an infinite loop causing the integration between time zero and the first time step to repeat indefinitely.
Description
The intention of this PR is to fix issue #998, which describes in detail what the problem and the proposed solution are.
Issue(s) addressed
Commit Message
In certain coupled configurations, the piece of code testing the coupling frequency to check if 'receive' coupling exchanges need to take place fail, resulting in an infinite loop causing the integration between time zero and the first time step to repeat indefinitely. This check needs to be rewritten, which fixes also issue #816 in a simpler way.
Check list
Testing