Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/ is not required at the end of the user-defined path #1388

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mingchen-NOAA
Copy link
Contributor

Pull Request Summary

Improved the user-defined directory feature that '/' is not required at the end of the paths.

Description

This pull request addresses an issue with path handling in user-defined directories. The trailing '/' is now optional when users specify their own paths. ww3_shel.F90 has been modified to handle user-defined paths with or without a trailing '/' correctly. model/nml/ww3_shel.nml was updated to provide an example configuration.

Issue(s) addressed

Improving PR #1369 to address issue #1221

Commit Message

make trailing '/' optional for user-defined directories

Check list

Testing

  • How were these changes tested?
    In matrix
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
    No, this is a user-defined directory that varies depending on the environment.
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?
    Orion, Intel
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

********************* non-identical cases ****************************


mww3_test_03/./work_PR3_UNO_MPI_e_c (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e (1 files differ)
mww3_test_03/./work_PR1_MPI_d2 (16 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2 (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2 (17 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2 (12 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c (12 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2 (17 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c (16 files differ)
mww3_test_03/./work_PR1_MPI_e (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e (1 files differ)
mww3_test_09/./work_MPI_ASCII (0 files differ)
ww3_tp2.10/./work_MPI_OMPH (7 files differ)
ww3_tp2.16/./work_MPI_OMPH (4 files differ)
ww3_tp2.6/./work_ST4_ASCII (0 files differ)
ww3_ufs1.3/./work_a (3 files differ)
matrixDiff.txt
matrixCompSummary.txt
matrixCompFull.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant