Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update w3srcemd.F90 for considering the contribution of ice scattering of IS1 #1387

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Biao-Zhao
Copy link
Contributor

I reported a bug #1386, the current IS1 is not contributing to action density spectrum. Since scattering doesn’t dissipate wave energy, I believe the correct solution is to redistribute the scattered energy to other directions, similar to IS2.

Pull Request Summary

Description

Issue(s) addressed

Commit Message

Check list

Testing

  • How were these changes tested?
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

I reported a bug in NOAA-EMC#1386, the current IS1 is not contributing to action density spectrum. Since scattering doesn’t dissipate wave energy, I believe the correct solution is to redistribute the scattered energy to other directions, similar to IS2.
@Biao-Zhao Biao-Zhao changed the title Update w3srcemd.F90 Update w3srcemd.F90 for considering the contribution of IS1 Mar 7, 2025
@Biao-Zhao Biao-Zhao changed the title Update w3srcemd.F90 for considering the contribution of IS1 Update w3srcemd.F90 for considering the contribution of ice scattering of IS1 Mar 7, 2025
…g of IS1

I reported a bug NOAA-EMC#1386, the current IS1 is not contributing to action density spectrum. Since scattering doesn’t dissipate wave energy, I believe the correct solution is to redistribute the scattered energy to other directions, similar to IS2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant