Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WAFS scripts and file names #24

Merged
merged 3 commits into from
May 24, 2024

Conversation

YaliMao-NOAA
Copy link
Collaborator

@YaliMao-NOAA YaliMao-NOAA commented May 24, 2024

  1. Remove gfs from all script filenames
  2. Change from gfs to wafs of the output grib2 filenames
  3. Remove GFS from dbn_alert
  4. Update forecast hour of the output grib2 filenames from 2 digits to 3 digits

The working and log files are at: /lfs/h2/emc/ptmp/yali.mao/working_wafs.new
The output files are at: /lfs/h2/emc/ptmp/yali.mao/wafs_dwn/

2. Change from gfs to wafs of the output grib2 filenames
3. Remove GFS from dbn_alert
4. Update forecat hour of the output grib2 filenames from 2 digits to 3 digits
@YaliMao-NOAA YaliMao-NOAA requested a review from aerorahul May 24, 2024 21:11
```bash
./sorc/build_all.sh
sh sorc/checkout_upp.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you forget to add, commit and push this file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. I thought I would modify it later when adding UPP. Just added it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure why instead of renaming from scripts/exgfs_atmos_wafs_gcip.sh, it is adding this file as new and deleting scripts/exgfs_atmos_wafs_gcip.sh

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When there is renaming and editing, sometimes based on how much editing, the changes appear as if a new file was added and old one was removed.

Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

  • gfs -> wafs in most scripts
  • introduce COMINgfs where there is a dependency on GFS data
  • add run.ver. There should also be a build.ver and it should be sourced in sorc/build_all.sh

Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
@YaliMao-NOAA YaliMao-NOAA merged commit 367580e into NOAA-EMC:develop May 24, 2024
@YaliMao-NOAA YaliMao-NOAA deleted the separationMay22 branch September 18, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants