Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated jasper version to 4.0.0 in develop workflow #209

Merged
merged 4 commits into from
Jun 23, 2023
Merged

updated jasper version to 4.0.0 in develop workflow #209

merged 4 commits into from
Jun 23, 2023

Conversation

edwardhartnett
Copy link
Contributor

@edwardhartnett edwardhartnett commented May 26, 2023 •
edited
Loading

Part of #187

CI updates and improvements.

@edwardhartnett edwardhartnett changed the title added g2-3.4.5 to develop workflow updated jasper version to 4.0.0 in develop workflow May 26, 2023
@edwardhartnett edwardhartnett marked this pull request as ready for review June 22, 2023 20:36
Hang-Lei-NOAA
Hang-Lei-NOAA approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@Hang-Lei-NOAA Hang-Lei-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the jasper/4.0.0 may not available on some machines and some other libs. That could be a problem for implementation. May need to push all jasper associated libraries make this update together.

@edwardhartnett
Copy link
Contributor Author

Jasper-4.0.0 is not required. This code still works with jasper-2.x and jasper-3.x.

This CI just ensures that jasper-4.0.0 also works.

@edwardhartnett edwardhartnett merged commit 11e33f5 into develop Jun 23, 2023
@edwardhartnett edwardhartnett deleted the ejh_5_26 branch June 23, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hang-Lei-NOAA Hang-Lei-NOAA Hang-Lei-NOAA approved these changes

@AlexanderRichert-NOAA AlexanderRichert-NOAA Awaiting requested review from AlexanderRichert-NOAA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edwardhartnett @Hang-Lei-NOAA