Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More obs ... #887

Merged
merged 4 commits into from
Jan 30, 2024
Merged

More obs ... #887

merged 4 commits into from
Jan 30, 2024

Conversation

guillaumevernieres
Copy link
Contributor

@guillaumevernieres
Copy link
Contributor Author

It's a lot of copy/pasting. I wonder if we should have an application that generates template yaml files for these sst retrieval ... humm.

@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT-Passed Automated testing with global-workflow successful on Orion labels Jan 29, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Jan 29, 2024
apchoiCMD
apchoiCMD previously approved these changes Jan 29, 2024
@emcbot
Copy link

emcbot commented Jan 29, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Mon Jan 29 21:42:02 UTC 2024 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Jan 29 22:27:08 UTC 2024
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Mon Jan 29 22:55:57 UTC 2024
Tests: 100% tests passed, 0 tests failed out of 52

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Jan 29, 2024
@AndrewEichmann-NOAA
Copy link
Collaborator

It's a lot of copy/pasting. I wonder if we should have an application that generates template yaml files for these sst retrieval ... humm.

How often are we going to be doing this?

Copy link
Collaborator

@AndrewEichmann-NOAA AndrewEichmann-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks right

ShastriPaturi
ShastriPaturi previously approved these changes Jan 30, 2024
Copy link
Collaborator

@ShastriPaturi ShastriPaturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @guillaumevernieres.

apchoiCMD
apchoiCMD previously approved these changes Jan 30, 2024
Copy link
Collaborator

@apchoiCMD apchoiCMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right-

apchoiCMD
apchoiCMD previously approved these changes Jan 30, 2024
Copy link
Collaborator

@AndrewEichmann-NOAA AndrewEichmann-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So no window for the SSTs?

@guillaumevernieres
Copy link
Contributor Author

So no window for the SSTs?

Yeah ... HELL NO @AndrewEichmann-NOAA :
1 - It's affecting the mixed layer, time scales of interests in 10's of minutes, we don't want to play gods with redating that obs type!
2 - have you seen how dense these obs are???

@guillaumevernieres guillaumevernieres merged commit fcf524c into develop Jan 30, 2024
5 checks passed
@RussTreadon-NOAA
Copy link
Contributor

@guillaumevernieres , this PR modified the submodule hashes for the following JEDI repos

The date is in ( ) on each line is the commit date for the given JEDI repo hash.

Here are the hashes we had in GDASApp develop at 446ffe7. This is the GDASApp develop before PR #887 was merged into develop.

GDASApp at 446ffe7 pointed at newer JEDI repo hashes.

Why do we need to move the submodule hashes back in time with PR #887?

@guillaumevernieres
Copy link
Contributor Author

Why do we need to move the submodule hashes back in time with PR #887?

We don't @RussTreadon-NOAA , my mistake ... Although I see 3 green checks on the review side!

I'll submit a PR reverting to what it was before.

@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/more-obs-for-soca branch March 28, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hera-GW-RT-Passed Automated testing with global-workflow successful on Hera orion-GW-RT-Passed Automated testing with global-workflow successful on Orion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More marine obs as part of the default list
6 participants