Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Data Atmosphere Coupling of GFDL Land Model #113

Merged
merged 38 commits into from
Oct 10, 2024

Conversation

JustinPerket
Copy link

Description of changes

Small modicaation of UFS field exchange for GFDL LM4.

For ufs-community/ufs-weather-model#2146

Specific notes

Contributors other than yourself, if any:

Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)

  • No changes to existing model expected

Any User Interface Changes (namelist or namelist defaults changes)?

Testing performed

Passes existing lnd CDEPS RTs

ufs-community/ufs-weather-model#2146 brings new lm4 CDEPS RTs

…am2lnd_nuopc

Conflicts:
	mediator/esmFldsExchange_nems_mod.F90
	mediator/fd_nems.yaml (deleted upstream)
After Justin Perket's hiatus. Code builds but does not run cleanly. However, given the complexity of the merge and the pace of upstream development, will
conclude this merge and resolve remaining issues with subsequent commits

Conflicts (hopefully) resolved:
	mediator/esmFldsExchange_nems_mod.F90
- fix so that exmFldsExchange doesn't assum LM4. Noe
- now gets name of LND_model
mostly remove old noah-comp vars
@JustinPerket JustinPerket marked this pull request as ready for review September 18, 2024 16:04
@FernandoAndrade-NOAA
Copy link

Testing on #2146 has completed, please continue with the merge.

@DeniseWorthen DeniseWorthen merged commit 24e9eed into NOAA-EMC:emc/develop Oct 10, 2024
DeniseWorthen pushed a commit to DeniseWorthen/CMEPS that referenced this pull request Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants