Create cplhist mode for dice #62
Conversation
Need model SST to be in K if (minval(So_t) .LT. 100.0_r8), convert C-->K
…e units of So_t based on namelist input
…nal sst_constant_value
There was a problem hiding this comment.
Thanks for adding this mode. It looks good to me. If you don't mind and add some information about the new coupling mode to doc/source/dice.rst. If we push these developments to ESCOMP/CDEPS we could generate the documentation over there. As I know there is no any change in the CIME interface. If it is easy to port from ocean or any similar data component it would be nice to add mods for CIME interface. I could see something that can be used in the following link:
cplhist under docs directory could help.
|
Thank you, @uturuncoglu. I will add documentation. For pushing to ESCOMP/CDEPS, I am unclear if I should make testing for this new datamode in CIME like the regression tests to be added for ufs-weather-model |
|
Hi, @binli2337 could you please review this CDEPS PR? |
|
Testing on #2186 has completed successfully, please continue with merging this PR. |
* Adapt docn_datamode_cplhist for dice_datamode_cplhist * Fix .or. and local variables have different names in docn and dice * Add Si_imask. Decide whether to have flds_i2o_per_cat for cplhist method. * Copy sea ice stream fields to export state fields via dshr_dfield_add * Switches So_t from C to K. Decide on which/add switch * Overwrite missing value of 0 K in Si_t * Handle So_t in C and K in docn_datamode_cplhist_mod.F90 Need model SST to be in K if (minval(So_t) .LT. 100.0_r8), convert C-->K * Only fill docn_datamode_cplhist export variables if associated. Handle units of So_t based on namelist input * Default convert SST C to K (as currently). Then switch based on optional sst_constant_value * Allow null return for taux too in dice/dice_datamode_cplhist_mod.F90 * Add doc for dice cplhist mode to dice.rst
Description of changes
A new dice_datamode_cplhist_mod is adapted from docn_datamode_cplhist_mod.
Existing sst_constant_value namelist value is used in docn_datamode_cplhist_advance to handle SST units in K and C.
Specific notes
Contributors other than yourself, if any:
CDEPS Issues Fixed (include github issue #): #61
Are there dependencies on other component PRs (if so list):
Are changes expected to change answers (bfb, different to roundoff, more substantial): bfb for existing and new for new datamode
Any User Interface Changes (namelist or namelist defaults changes):
Testing performed (e.g. aux_cdeps, CESM prealpha, etc): UFS regression testing (ufs-community/ufs-weather-model#2186)
Hashes used for testing: See ufs-community/ufs-weather-model#2186