Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create cplhist mode for dice #62

Merged
merged 11 commits into from
Jun 11, 2024

Conversation

NickSzapiro-NOAA
Copy link
Collaborator

Description of changes

A new dice_datamode_cplhist_mod is adapted from docn_datamode_cplhist_mod.
Existing sst_constant_value namelist value is used in docn_datamode_cplhist_advance to handle SST units in K and C.

Specific notes

Contributors other than yourself, if any:

CDEPS Issues Fixed (include github issue #): #61

Are there dependencies on other component PRs (if so list):

Are changes expected to change answers (bfb, different to roundoff, more substantial): bfb for existing and new for new datamode

Any User Interface Changes (namelist or namelist defaults changes):

Testing performed (e.g. aux_cdeps, CESM prealpha, etc): UFS regression testing (ufs-community/ufs-weather-model#2186)

Hashes used for testing: See ufs-community/ufs-weather-model#2186

Copy link
Collaborator

@uturuncoglu uturuncoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this mode. It looks good to me. If you don't mind and add some information about the new coupling mode to doc/source/dice.rst. If we push these developments to ESCOMP/CDEPS we could generate the documentation over there. As I know there is no any change in the CIME interface. If it is easy to port from ocean or any similar data component it would be nice to add mods for CIME interface. I could see something that can be used in the following link:

<stream_entry name="cplhist">
but not sure about all the changes that are required. Maybe searching cplhist under docs directory could help.

@NickSzapiro-NOAA
Copy link
Collaborator Author

Thank you, @uturuncoglu. I will add documentation.

For pushing to ESCOMP/CDEPS, I am unclear if I should make testing for this new datamode in CIME like the regression tests to be added for ufs-weather-model

@NickSzapiro-NOAA NickSzapiro-NOAA linked an issue May 18, 2024 that may be closed by this pull request
@zach1221
Copy link

Hi, @binli2337 could you please review this CDEPS PR?

@NickSzapiro-NOAA NickSzapiro-NOAA requested a review from jkbk2004 May 30, 2024 15:24
@FernandoAndrade-NOAA
Copy link

Testing on #2186 has completed successfully, please continue with merging this PR.

@NickSzapiro-NOAA NickSzapiro-NOAA merged commit fbdf684 into NOAA-EMC:develop Jun 11, 2024
@NickSzapiro-NOAA NickSzapiro-NOAA deleted the dice_cplhist branch June 18, 2024 22:20
NickSzapiro-NOAA added a commit to NickSzapiro-NOAA/CDEPS that referenced this pull request Jul 23, 2024
* Adapt docn_datamode_cplhist for dice_datamode_cplhist

* Fix .or. and local  variables have different names in docn and dice

* Add Si_imask. Decide whether to have flds_i2o_per_cat for cplhist method.

* Copy sea ice stream fields to export state fields via dshr_dfield_add

* Switches So_t from C to K. Decide on which/add switch

* Overwrite missing value of 0 K in Si_t

* Handle So_t in C and K in docn_datamode_cplhist_mod.F90

Need model SST to be in K
if (minval(So_t) .LT. 100.0_r8), convert C-->K

* Only fill docn_datamode_cplhist export variables if associated. Handle units of So_t based on namelist input

* Default convert SST C to K (as currently). Then switch based on optional sst_constant_value

* Allow null return for taux too in dice/dice_datamode_cplhist_mod.F90

* Add doc for dice cplhist mode to dice.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create cplhist mode for dice
5 participants