Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESMF_IOFMT_BIN deprecated in ESMF 8.4.0. #5

Closed
BrianCurtis-NOAA opened this issue Aug 4, 2022 · 1 comment · Fixed by ufs-community/ufs-weather-model#1456
Closed

ESMF_IOFMT_BIN deprecated in ESMF 8.4.0. #5

BrianCurtis-NOAA opened this issue Aug 4, 2022 · 1 comment · Fixed by ufs-community/ufs-weather-model#1456
Assignees
@BrianCurtis-NOAA
Labels
bug Something isn't working

Comments

@BrianCurtis-NOAA
Copy link
Collaborator

Issue: ESMF_IOFMT_BIN is deprecated in v8.4.0.

Fix:We have one call to ESMF_IOFMT_BIN in

AQM/src/io/aqmio/aqmio.F90

Line 445 in 9fd5978

else if (liofmt == ESMF_IOFMT_BIN) then
but according to @JianpingHuang-NOAA there is no reading or writing of binary data in AQM and this section of code can be removed.
@BrianCurtis-NOAA BrianCurtis-NOAA added the bug Something isn't working label Aug 4, 2022
@BrianCurtis-NOAA BrianCurtis-NOAA self-assigned this Aug 4, 2022
@BrianCurtis-NOAA BrianCurtis-NOAA changed the title ESMF_IOFMT_BIN deprecated. ESMF_IOFMT_BIN deprecated in ESMF 8.4.0. Aug 12, 2022
@BrianCurtis-NOAA
Copy link
Collaborator Author

Current plans are to not delete/remove the code but find a way to keep it available to users. If a fix isn't identified soon, and the ESMF 8.4 is ready to be used in UFSWM, then I will comment out the code and make sure an issue is addressed in github for a more permanent fix.

This was referenced Oct 27, 2022
Closed
Closed
Merged
JianpingHuang-NOAA pushed a commit to JianpingHuang-NOAA/AQM that referenced this issue Apr 22, 2024
@ytangnoaa
Merge pull request NOAA-EMC#5 from noaa-oar-arl/feature/pt-source
5dfea1b 
Feature/pt source
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrianCurtis-NOAA BrianCurtis-NOAA

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@BrianCurtis-NOAA