Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default logging parameters to be clearcut rather than reduced-impact #1359

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ckoven
Copy link
Contributor

@ckoven ckoven commented Mar 13, 2025

Description:

These changes to the parameter file make harvest be clear-cut rather than reduced-impact logging. The argument is that that is more consistent with how the global land use datasets are treating logging. Ideally it would be better to have regionally- (and temporally-) differentiated logging parameters, but for initial global simulations, this endmember assumption is probably the place to start from.

Collaborators:

Expectation of Answer Changes:

This will change answers in all configurations that include logging.

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

  • The in-code documentation has been updated with descriptive comments
  • The documentation has been assessed to determine if updates are necessary

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided

Documentation

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

@glemieux glemieux added inputs: parameter file Pertaining to changes to the FATES parameter file science: harvesting parameters: value change Pertaining to changes to the parameter file only (i.e. not removing or adding new parameters) labels Mar 13, 2025
@glemieux glemieux moved this to Finding Reviewers in FATES Pull Request Planning and Status Mar 24, 2025
@glemieux glemieux requested a review from mpaiao March 24, 2025 19:17
@glemieux
Copy link
Contributor

FYI @sshu88 would you take a look at this when you have a moment, please?

@sshu88
Copy link
Contributor

sshu88 commented Mar 24, 2025

FYI @sshu88 would you take a look at this when you have a moment, please?

These revisions make sense for global default simulation. Thanks for working on it.

@glemieux glemieux moved this from Finding Reviewers to Under Review in FATES Pull Request Planning and Status Mar 25, 2025
@glemieux glemieux moved this from Under Review to Final Testing in FATES Pull Request Planning and Status Mar 27, 2025
Copy link
Contributor

@mpaiao mpaiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ckoven, I just checked the parameter updates, and they look good to me for making the clearcut the default.

In principle, logging characteristics could vary spatially, so these parameters could eventually be migrated to the land use files. This is very low priority though, I am not aware of any such dataset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inputs: parameter file Pertaining to changes to the FATES parameter file parameters: value change Pertaining to changes to the parameter file only (i.e. not removing or adding new parameters) science: harvesting
Projects
Status: Final Testing
Development

Successfully merging this pull request may close these issues.

4 participants