Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change comp_excln parameter to -1 (rank-ordered, deterministic sorting) #1358

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ckoven
Copy link
Contributor

@ckoven ckoven commented Mar 13, 2025

This changes the default value of the comp_excln parameter to -1. This leads to the use of the rank-ordered sorting scheme, rather than the current-default probabilistic scheme. The main reason for doing this is that it results in fewer cohorts and therefore makes the model faster, which may be particularly important when increasing the number of canopy layers in #1315. It also has the effect of tending to slightly favor early-successional PFTs, as shown in fig. 13 of Koven et al, 2020, though that is not something that will show up in the kind of global nocomp and SP-mode simulations that this parameter file is currently mainly being aimed at.

Description:

Collaborators:

Expectation of Answer Changes:

This will change answers in all cases other than SP.

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

  • The in-code documentation has been updated with descriptive comments
  • The documentation has been assessed to determine if updates are necessary

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided

Documentation

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

@glemieux glemieux added inputs: parameter file Pertaining to changes to the FATES parameter file parameters: value change Pertaining to changes to the parameter file only (i.e. not removing or adding new parameters) science: canopy structure Pertaining to canopy structure including perfect plasticity approximation (PPA) labels Mar 13, 2025
@glemieux glemieux moved this to Finding Reviewers in FATES Pull Request Planning and Status Mar 17, 2025
@glemieux glemieux requested a review from rosiealice March 17, 2025 22:38
@glemieux glemieux moved this from Finding Reviewers to Under Review in FATES Pull Request Planning and Status Mar 24, 2025
Copy link
Contributor

@rosiealice rosiealice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good idea, as we noted, most of our implementations at the moment do not use the competition feature, leading to large duplication of cohorts betweem canopy layers, so this will likely provide non-trivial efficiencies....

@github-project-automation github-project-automation bot moved this from Under Review to Final Testing in FATES Pull Request Planning and Status Mar 24, 2025
@glemieux
Copy link
Contributor

glemieux commented Apr 2, 2025

@ckoven should this close #303?

@ckoven
Copy link
Contributor Author

ckoven commented Apr 2, 2025

@ckoven should this close #303?

That is so old I don't really remember the nature of the problem, but probably?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inputs: parameter file Pertaining to changes to the FATES parameter file parameters: value change Pertaining to changes to the parameter file only (i.e. not removing or adding new parameters) science: canopy structure Pertaining to canopy structure including perfect plasticity approximation (PPA)
Projects
Status: Final Testing
Development

Successfully merging this pull request may close these issues.

3 participants