SPITFIRE refactor of mortality #1357
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemieux
added
type: refactor
|
During the fates-ctsm standup this morning, @adrifoster noted that we should bring in #1360 (and #1362?) prior to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the SPITFIRE code for tree mortality.
Description:
Should be bit-for-bit. Just reorganizes the subroutines and creates some helper functions and unit tests
Expectation of Answer Changes:
Should be bit 4 bit
Checklist
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
Test Results:
Ran preliminary tests that were b4b- will run again
CTSM (or) E3SM (specify which) test hash-tag:
ctsm5.3.029CTSM (or) E3SM (specify which) baseline hash-tag:
ctsm5.3.029FATES baseline hash-tag:
sci.1.81.1_api.38.0.0Test Output: