Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:select): change order for clear and arrow #6245

Merged
merged 1 commit into from
Dec 31, 2020

Conversation

rencoo
Copy link
Contributor

@rencoo rencoo commented Dec 22, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

can clear content when clear and arrow icon overlap in nz-select component

Issue Number: N/A
#5989

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@rencoo rencoo requested a review from vthinkxie as a code owner December 22, 2020 07:53
@zorro-bot
Copy link

zorro-bot bot commented Dec 22, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #6245 (b7d8a27) into master (a4dbe23) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6245      +/-   ##
==========================================
- Coverage   89.80%   89.79%   -0.02%     
==========================================
  Files         477      477              
  Lines       15186    15186              
  Branches     2298     2298              
==========================================
- Hits        13638    13636       -2     
- Misses        949      951       +2     
  Partials      599      599              
Impacted Files Coverage Δ
components/select/select.component.ts 87.86% <ø> (ø)
components/tabs/tab-nav-bar.component.ts 81.69% <0.00%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4dbe23...b7d8a27. Read the comment docs.

Copy link
Member

@wenqi73 wenqi73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rencoo Thanks!

@wenqi73 wenqi73 merged commit c822073 into NG-ZORRO:master Dec 31, 2020
@rencoo rencoo deleted the fix-5989 branch January 16, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants