Author type enum #614
Merged
Author type enum #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunnarvelle
force-pushed
the
author-type-enum
branch
2 times, most recently
from
f13bcb9 to
f2f95c4
Compare
gunnarvelle
force-pushed
the
author-type-enum
branch
from
f2f95c4 to
de48c37
Compare
jnatten
reviewed
Feb 27, 2025
article-api/src/main/scala/no/ndla/articleapi/validation/ContentValidator.scala
Show resolved
Hide resolved
Comment on lines
+46
to
+53
| private def convertAuthors(authors: List[OldAuthor]): List[Author] = { | ||
| authors.map(author => { | ||
| ContributorType.valueOf(author.`type`.toLowerCase) match { | ||
| case None => Author(ContributorType.mapping(author.`type`.toLowerCase), author.name) | ||
| case Some(a) => Author(a, author.name) | ||
| } | ||
| }) | ||
| } |
There was a problem hiding this comment.
Jeg henger ikke helt med på hvorfor denne migreringen trengs jeg.
Er det færre mulige typer nå, eller har de andre navn?
Må vi endre frontend?
There was a problem hiding this comment.
Nei, vi må ikkje endre frontend. Men vi har en toLower i frontend som vi kan droppe. Hovedpoenget med dette er å få samme verdier overalt. I article og draft er det mest Writer og writer som er forskjellene, men i learningpath er det Forfatter. Dette sikrer at alt er lowercase og kan knyttes til enum.
common/src/main/scala/no/ndla/common/model/domain/ContributorType.scala
Outdated
Show resolved
Hide resolved
gunnarvelle
commented
Feb 27, 2025
| |} | ||
| |""".stripMargin | ||
|
|
||
| val expected = parser.parse(newDocument).toTry.get |
There was a problem hiding this comment.
Synes dette var greit slik så slipper vi å ha expected på ei lang linje.
gunnarvelle
force-pushed
the
author-type-enum
branch
from
ac0e741 to
2bc4a1f
Compare
gunnarvelle
force-pushed
the
author-type-enum
branch
from
2bc4a1f to
1f468c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Innfører enum for ContributorType slik at vi får ordentlig validering på lisensinfo.
Migrerer alt av eksisterende lisenser slik at disse blir i henhold til ny enum. Har også endra validering slik at vi dropper sjekk om type er korrekt siden serialisering vil feile dersom det er feil og dermed vil det aldri treffe valideringa. Innfører heller sjekk på at navn på author er større enn 0.