Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyfive: test failure on groups #1

Closed
bnlawrence opened this issue Jul 10, 2024 · 2 comments
Closed

pyfive: test failure on groups #1

bnlawrence opened this issue Jul 10, 2024 · 2 comments

Comments

@bnlawrence
Copy link
Collaborator

As it stands, pyfive branch commit 04ae240 fails in test_h5netcdf_pyfive at

    assert set(ds.groups) == set(["subgroup"])

where the debugger tells me that
set(ds.groups) = {'enum_t', 'subgroup'} instead of {subgropu}

Suspect that'll be to do with my various hacks for Datatype and check_enum_dtype ... to investigate.

@bnlawrence
Copy link
Collaborator Author

The debugger tells me that in the h5py normal version, ds.groups in advance of the set looks like this:

ds.groups
{'subgroup': <class 'netCDF4._netCDF4.Group'>
group /subgroup:
    dimensions(sizes): y(10)
    va...2 subvar(x), float64 y_var(y)
    groups: }
special variables
function variables
'subgroup':
<class 'netCDF4._netCDF4.Group'>
group /subgroup:
    dimensions(sizes): y(10)
    variables(dimensions): int32 subvar(x), float64 y_var(y)
    groups: 
len():
1
set(ds.groups)
{'subgroup'}

By contrast, in advance of the set, in the pyfive version, it looks like this:

ds.groups
Frozen(<h5netcdf.core._LazyObjectLookup object at 0x106c934d0>)

@bnlawrence
Copy link
Collaborator Author

It turns out this was a problem with enumerations which are not supported by pyfive, but were being erroneously treated as groups (my pyfive issue #8).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant