JOSS paper text & documentation revisions #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
The Actions workflow test runs are irrelevant, as these changes are all to the JOSS paper.md and documentation, which we do not test on.
But I have tested this in a custom, appropriate manner by supplying the repo & branch corresponding to this PR to the Whedon preview service (putting https://github.com/sadielbartholomew/cfdm/ & joss-paper into the two text fields & compiling for JOSS) and looking over the updated paper as it would be rendered in the journal. All seems fine there. I've also built a dev version of the documentation from this branch and can't fault the updated pages.
Happy to merge as have discussed these changes externally already.
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor amendments to the JOSS paper text and the documentation in response to feedback from the first reviewer. See commit messages for a breakdown of the set of precise changes.
Merging these together as a PR so they can be viewed as one whole, as that may be preferred for the purposes of further review.