Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpret format specifiers for size 1 arrays #153

Merged
merged 2 commits into from
Aug 25, 2021

Conversation

davidhassell
Copy link
Contributor

Fixes #152

@davidhassell davidhassell added this to the 1.9.0.0 milestone Aug 25, 2021
@davidhassell davidhassell self-assigned this Aug 25, 2021
@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #153 (e008a1b) into master (f760739) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
+ Coverage   88.75%   88.76%   +0.01%     
==========================================
  Files         101      101              
  Lines       10505    10512       +7     
==========================================
+ Hits         9323     9330       +7     
  Misses       1182     1182              
Flag Coverage Δ
unittests 88.76% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cfdm/data/data.py 84.61% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f760739...e008a1b. Read the comment docs.

Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolves the corresponding issue and the test looks sufficiently thorough, with the possible exception I thought of being masked values, for which a warning does crop up with the PR as-is, so I have added a minor tweak as a suggestion to handle that.

Otherwise this is all good, so please merge when you are happy.

@sadielbartholomew sadielbartholomew merged commit ac0bae4 into NCAS-CMS:master Aug 25, 2021
@davidhassell davidhassell deleted the data-format branch November 14, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement __format__ on cfdm.Data objects
2 participants