Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mock s3 test #232

Merged
merged 13 commits into from
Jan 14, 2025
Merged

Add mock s3 test #232

merged 13 commits into from
Jan 14, 2025

Conversation

valeriupredoi
Copy link
Collaborator

@valeriupredoi valeriupredoi commented Jan 8, 2025

Description

We mock an entire S3 fsspec/s3fs-like File System, pop a working HTTP client on top of it, and add a real POSIX file to it, then access it as if it was a real file but in an S3 s3fs-like FS. Wild Weasel YGBSM stuff 😁

Before you get started

Checklist

  • This pull request has a descriptive title and labels
  • This pull request has a minimal description (most was discussed in the issue, but a two-liner description is still desirable)
  • Unit tests have been added (if codecov test fails)
  • Any changed dependencies have been added or removed correctly (if need be)
  • All tests pass

@valeriupredoi valeriupredoi marked this pull request as draft January 8, 2025 22:46
@valeriupredoi valeriupredoi marked this pull request as ready for review January 9, 2025 13:30
@valeriupredoi valeriupredoi added the testing testing duh label Jan 9, 2025
@valeriupredoi valeriupredoi merged commit 0e43748 into main Jan 14, 2025
9 checks passed
@valeriupredoi valeriupredoi deleted the add_mock_s3_test branch January 14, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing testing duh
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant