CMake Build Improvements #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `make; make install` command will report success even if the first Make process failed. The result of this compound expression is passed to the code that prints success/failure to the user. Fixed by switching to `make && make install` to chain the result codes.
Use IEEE_ARITHMETIC's ieee_is_nan() instead of compiler-specific intrinsics for broader compatibility.
* Use find_package(MPI required) instead of overriding compiler binaries * Add support for PGI (and NVHPC) in CMake build system * Update minimum CMake to 3.0
|
These changes look good to me. The only thing I would recommend, if you want to, is to remove the |
|
It would be nice to remove the minimum version from each file -- I did a grep to change it out thinking that it wasn't inherited from the upstream CMakeLists.txt. I'll make that change. |
rcabell
force-pushed
the
build-improvements
branch
from
8b236f0 to
d7ffafa
Compare
scrasmussen
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: bugfix/enhancement
KEYWORDS: build, CMake, PGI, gfortran9
SOURCE: WRF-Hydro Team @ NCAR
DESCRIPTION OF CHANGES:
In the classic build system, don't report success if the underlying Make process failed.
In CMake build system, remove
-fallow-argument-mismatchfrom gfortran flags, since this breaks compatibiilty with older GNU suites (< v10) and not needed anymore withuse netcdfUpdate the CMake build system to use FIND_MPI() and not override the compiler variables with static
mpif90wrapper scripts. This also explicitly links MPI libaries to modules that require it.Support PGI (> v20) and NVHPC in CMake:
use ieee_arithmetic, only: isnan => ieee_is_nanto CROCUS since PGI doesn't support isnan() intrinsic (this may help on other compilers too)ISSUES:
TESTS CONDUCTED: pending
Checklist
Merging the PR depends on following checklist being completed. Add
Xbetween each of the squarebrackets if they are completed in the PR itself. If a bullet is not relevant to you, please comment
on why below the bullet.
NEWS.md