Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UFS-dev PR#14 #73

Merged
merged 17 commits into from
Nov 15, 2022
Merged

UFS-dev PR#14 #73

merged 17 commits into from
Nov 15, 2022

Conversation

grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented Nov 3, 2022 •
edited
Loading

Identical to ufs-community#1460
Contains changes from #72 (that will be merged first)

Baseline change due to newly added RT only.

ChunxiZhang-NOAA and others added 3 commits November 1, 2022 11:31
@ChunxiZhang-NOAA @jkbk2004 @BrianCurtis-NOAA
[FV3] Add a new RT for the SDF FV3_WoFS_v0 (ufs-community#1460)
84b28ec 
* Add a new RT for SDF FV3_WoFS_v0

* Update delta_srw210 branch in ccpp/physics and minor bug fix in CCPP_typedefs

Co-authored-by: JONG KIM <jong.kim@noaa.gov>
Co-authored-by: Brian Curtis <brian.curtis@noaa.gov>
update .gitmodules for testing and FV3 submodule pointer
e5bf935
Merge commit '84b28ec' into ufs-dev-PR14
7fc14e1
@dustinswales
Copy link
Collaborator

@grantfirl Read to test. Can you update the downstream submodules?

@grantfirl
Copy link
Collaborator Author

@dustinswales Done, ready to test. Looks like BL should only change due to new RT.

[AutoRT] cheyenne.gnu Job Completed.
e366d2c 
on-behalf-of @NCAR <dswales@ucar.edu>
[AutoRT] hera.gnu Job Completed.
a3ead35 
on-behalf-of @NCAR <dswales@ucar.edu>
@dustinswales
Copy link
Collaborator

Automated RT Failure Notification
Machine: cheyenne
Compiler: intel
Job: RT
[RT] Repo location: /glade/scratch/epicufsrt/GMTB/ufs-weather-model/RT/auto_RT/Pull_Requests/1109974330/20221108163823/ufs-weather-model
[RT] Error: Test regional_3km_wofs 053 failed in check_result failed
[RT] Error: Test regional_3km_wofs 053 failed in run_test failed
Please make changes and add the following label back: cheyenne-intel-RT

@dustinswales
Copy link
Collaborator

Automated RT Failure Notification
Machine: hera
Compiler: intel
Job: RT
[RT] Repo location: /scratch1/BMC/gmtb/RT/auto_RT/Pull_Requests/1109974330/20221109000113/ufs-weather-model
[RT] Error: Test regional_3km_wofs 056 failed in check_result failed
[RT] Error: Test regional_3km_wofs 056 failed in run_test failed
Please make changes and add the following label back: hera-intel-RT

[AutoRT] cheyenne.gnu Job Completed.
df11df7 
on-behalf-of @NCAR <dswales@ucar.edu>
[AutoRT] hera.gnu Job Completed.
ec01176 
on-behalf-of @NCAR <dswales@ucar.edu>
dustinswales added 2 commits November 14, 2022 20:48
[AutoRT] hera.intel Job Completed.
d902ae3 
on-behalf-of @NCAR <dswales@ucar.edu>
[AutoRT] cheyenne.intel Job Completed.
b9362d0 
on-behalf-of @NCAR <dswales@ucar.edu>
[AutoRT] cheyenne.gnu Job Completed.
80ef337 
on-behalf-of @NCAR <dswales@ucar.edu>
[AutoRT] hera.gnu Job Completed.
3eb48f1 
on-behalf-of @NCAR <dswales@ucar.edu>
@dustinswales dustinswales self-requested a review November 15, 2022 02:31
dustinswales
dustinswales approved these changes Nov 15, 2022
View reviewed changes
Copy link
Collaborator

@dustinswales dustinswales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests look good.

dustinswales added 2 commits November 15, 2022 02:35
[AutoRT] hera.intel Job Completed.
fcadc7f 
on-behalf-of @NCAR <dswales@ucar.edu>
[AutoRT] cheyenne.intel Job Completed.
a63925a 
on-behalf-of @NCAR <dswales@ucar.edu>
@dustinswales
Copy link
Collaborator

@grantfirl You are good to update the submodules and merge whenever you have time.

@grantfirl
Copy link
Collaborator Author

@grantfirl You are good to update the submodules and merge whenever you have time.

@dustinswales Please approve NCAR/fv3atm#72 when you get a minute.

@grantfirl grantfirl merged commit 8d3a8a4 into NCAR:main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustinswales dustinswales dustinswales approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grantfirl @dustinswales @ChunxiZhang-NOAA