Skip to content

Model check-pointing and early-stopping fixes for base_trainer #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 19, 2024
Merged

Model check-pointing and early-stopping fixes for base_trainer #81

merged 11 commits into from
Aug 19, 2024

Conversation

yingkaisha
Copy link
Collaborator

@yingkaisha yingkaisha commented Aug 16, 2024 •
edited
Loading

  • Add the new feature in base_trainer.py to save the "best" checkpoint based on validation set performance.
  • Add the new feature in base_trainer.py to save the "previous epoch" checkpoint
  • Update config.yml and credit.parser based on the new features.
  • Clean up and add documentation to data.py and transforms.py.

@yingkaisha yingkaisha marked this pull request as draft August 16, 2024 18:00
@yingkaisha yingkaisha marked this pull request as ready for review August 17, 2024 16:25
@yingkaisha yingkaisha requested a review from jsschreck August 17, 2024 16:25
@yingkaisha yingkaisha marked this pull request as draft August 17, 2024 18:59
@yingkaisha yingkaisha marked this pull request as ready for review August 17, 2024 18:59
@yingkaisha yingkaisha marked this pull request as draft August 18, 2024 17:02
@yingkaisha yingkaisha changed the title Mdeol check-pointing and early-stopping fixes for base_trainer Model check-pointing and early-stopping fixes for base_trainer Aug 18, 2024
@yingkaisha yingkaisha marked this pull request as ready for review August 19, 2024 16:20
jsschreck
jsschreck approved these changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@jsschreck jsschreck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you please just add the [optional] config variables: "training_metric" (or something) and direction? Then its good to go!

@yingkaisha yingkaisha merged commit 2b50d95 into main Aug 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsschreck jsschreck jsschreck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yingkaisha @jsschreck