New solar processing and bridgescaler state scaler #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # config/wxformer_6hr.yml
# Conflicts: # credit/data.py
|
We can merge I will look at the solar part later today. |
yingkaisha
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solar: I redid the solar calculation to generate solar irradiance for every hour of ERA5 and account for variations in the solar constant, orbital effects, and the correct time of day for every point. I have added unit tests for solar to handle this.
Transforms: I have a new BridgescalerScaleState that can perform transforms and inverse transforms with bridgescaler DStandardScaler and DQuantileScaler objects. Currently the class aggregates all scaler objs but need to add option to only aggregate across certain dates.