Skip to content

Fuxi update #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 11, 2024
Merged

Fuxi update #47

merged 12 commits into from
Jun 11, 2024

Conversation

jsschreck
Copy link
Collaborator

No description provided.

@jsschreck jsschreck requested a review from yingkaisha June 6, 2024 15:25
@jsschreck
Copy link
Collaborator Author

This will now support adding these options to the config file under model:

pad_lon: 80
pad_lat: 80
use_spectral_norm: True

@djgagne
Copy link
Collaborator

djgagne commented Jun 11, 2024

From flake8

diagnostics.py:119:46: F821 undefined name 'ZonalEnergySpectrum'

Please add the correct import.

yingkaisha
yingkaisha reviewed Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@yingkaisha yingkaisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

yingkaisha
yingkaisha approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@yingkaisha yingkaisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@yingkaisha yingkaisha merged commit d686f4e into main Jun 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yingkaisha yingkaisha yingkaisha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsschreck @djgagne @yingkaisha