Removed references to rrtmg_lw_init and rrtmg_sw_init #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-a-potts
requested review from
mjiacono,
Qingfu-Liu,
climbfuji,
SamuelTrahanNOAA,
grantfirl,
mzhangw,
panll,
mkavulich and
ChunxiZhang-NOAA
as code owners
grantfirl
approved these changes
Jun 8, 2022
|
Since it was merged already, do you want me to submit a PR to remove *_finalize in both subroutines?
… On Jun 8, 2022, at 10:16 AM, Grant Firl ***@***.***> wrote:
Merged #939 <#939> into release/public-v6.
—
Reply to this email directly, view it on GitHub <#939 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AG7TW2VEZICFNLKTQ6MDZZTVODBPTANCNFSM5YHC54UA>.
You are receiving this because your review was requested.
|
|
That would be awesome. Thanks!
-M
On 6/8/22 12:19 PM, mzhangw wrote:
Since it was merged already, do you want me to submit a PR to remove
*_finalize in both subroutines?
> On Jun 8, 2022, at 10:16 AM, Grant Firl ***@***.***> wrote:
>
>
> Merged #939 <#939> into
release/public-v6.
>
> —
> Reply to this email directly, view it on GitHub
<#939 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG7TW2VEZICFNLKTQ6MDZZTVODBPTANCNFSM5YHC54UA>.
> You are receiving this because your review was requested.
>
—
Reply to this email directly, view it on GitHub
<#939 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH4Q2UQVWI5KKKKZXSFWRW3VODBZ7ANCNFSM5YHC54UA>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
--
Mark A. Potts, Ph.D.
NOAA EPIC Lead Software Engineer
RedLine Performance Solutions, LLC
Phone 202-744-9469
***@***.***
***@***.***
|
|
@mzhangw No, in my opinion, we should not touch this branch anymore. Rather than removing these empty subroutines piecemeal, we should do a comprehensive cleanup later on the main branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed undefined references for use with ufs-weather-model release/public-v3 branch used by SRW release/public-v2.
Fixes issue #938