Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed references to rrtmg_lw_init and rrtmg_sw_init #939

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

mark-a-potts
Copy link

@mark-a-potts mark-a-potts commented Jun 8, 2022

Removed undefined references for use with ufs-weather-model release/public-v3 branch used by SRW release/public-v2.

Fixes issue #938

Copy link
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mark-a-potts.

@grantfirl grantfirl merged commit 01c6766 into NCAR:release/public-v6 Jun 8, 2022
@mzhangw
Copy link
Collaborator

mzhangw commented Jun 8, 2022 via email

@mark-a-potts
Copy link
Author

mark-a-potts commented Jun 8, 2022 via email

@grantfirl
Copy link
Collaborator

@mzhangw No, in my opinion, we should not touch this branch anymore. Rather than removing these empty subroutines piecemeal, we should do a comprehensive cleanup later on the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants