Update NSSL microphysics to fix ORT restart and decomposition tests #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicroTed
commented
Apr 22, 2022
| @@ -2884,7 +2884,7 @@ SUBROUTINE nssl_2mom_driver(qv, qc, qr, qi, qs, qh, qhl, ccw, crw, cci, csw, chw | |||
| IF ( lccn > 1 .and. is_aerosol_aware .and. flag_qnwfa ) THEN | |||
| ! not used here | |||
| ELSEIF ( present( cn ) .and. lccn > 1 .and. .not. flag_qndrop) THEN | |||
| IF ( lccna > 1 .and. .not. present( cna ) ) THEN | |||
| IF ( lccna > 1 .and. .not. ( present( cna ) .and. f_cnatmp ) ) THEN | |||
There was a problem hiding this comment.
Note that this change is not directly related to the issue, but it was a logic error found along the way (no effect, because lccna=0 for current uses in CCPP)
There was a problem hiding this comment.
Great to know that you fixed this logic error.
MicroTed
requested review from
climbfuji,
SamuelTrahanNOAA,
grantfirl,
mzhangw,
panll,
mkavulich and
ChunxiZhang-NOAA
as code owners
grantfirl
approved these changes
Apr 22, 2022
There was a problem hiding this comment.
These changes all look fine to me. @junwang-noaa Should we point NOAA-EMC/fv3atm#514 to this branch for UFS RTs?
mzhangw
approved these changes
Apr 22, 2022
16 tasks
|
@grantfirl Yes, please point to fv3atm PR#504 so that we can get the reproducibility issue fixed in Ted's ufs PR. |
ChunxiZhang-NOAA
approved these changes
Apr 22, 2022
|
Fixes #916 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process of adding a new suite, it was found that rrfs_v1nssl did not pass the ORT restart (rst) and decomposition (dcp) tests. Both of these failures were tracked to mp_nssl.F90. The restart issue simply needed extra logic (using the 'restart' flag) to control the running of a subroutine on the first time step. The dcp test seems to be solved by replacing 0.0 with 0.0_rkind_phys.
ORT tests run on hera
RT for rrfs_v1nssl run on jet
Fixes issue raised in NOAA-EMC/fv3atm#514