Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapper for #808 and #816 #818

Merged
merged 10 commits into from
Dec 23, 2021
Merged

Wrapper for #808 and #816 #818

merged 10 commits into from
Dec 23, 2021

Conversation

grantfirl
Copy link
Collaborator

This pull request contains the following 2 pull requests, combined to save UFS regression test time:

#808 (Modification of momentum roughness length over ice in the surface layer scheme - RT baseline change for suites using sfc_diff.f and that have ice present)
#816 (fix the tsurf issue in Noah MP driver - should be no RT affects)

@grantfirl
Copy link
Collaborator Author

Status: Currently testing #808 to see exactly which RTs fail; will test #816 to make sure RTs all pass. Will create draft upstream PRs now.

@grantfirl
Copy link
Collaborator Author

Copy link
Collaborator

@SamuelTrahanNOAA SamuelTrahanNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving changes others have already approved in separate PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants