update to deep convection generic interstitials #119
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated GFS_DCNV_generic_pre/post to no longer use GFS DDTs since their use limited other models in their data organization. This required passing in many new variables that had previously been part of DDTs. Some corresponding new standard names were added in GFS_typedefs in FV3 and in gmtb_scm_type_defs in SCM. In addition, there was a code stanza added to not break gocart functionality (even though this is not operational) since it would have needed to have been done at some point anyway! Code related to determining array indices for the 'phy_f3d' variable was removed since it was already included in a subroutine within GFS_typedefs during initialization. Instead, the correct portion of phy_f3d is passed in to the routine (using the previously calculated value of ncnvw).