Skip to content

Commit

Permalink
Merge branch 'move_sfc_emis_alb_calculation_to_its_own_scheme_and_z0_…
Browse files Browse the repository at this point in the history
…composite_consistent' into move_sfc_emis_alb_calculation_to_its_own_scheme_and_z0_composite_consistent_gjf
  • Loading branch information
grantfirl committed May 18, 2021
2 parents 329364b + 60b873f commit 7468bf8
Show file tree
Hide file tree
Showing 5 changed files with 187 additions and 112 deletions.
33 changes: 33 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
---
name: Bug report
about: Create a report to help us improve
title: ''
labels: bug
assignees: ''

---

# Description

Provide a clear and concise description of the bug and what behavior you are expecting.

## Steps to Reproduce

Please provide detailed steps for reproducing the issue.

1. step 1
2. step 2
3. see the bug...

## Additional Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

* Machine
* Compiler
* Suite Definition File or Scheme
* Reference other issues or PRs in other repositories that this is related to, and how they are related.

## Output

Please include any relevant log files, screenshots or other output here.
20 changes: 20 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
---
name: Feature request
about: Suggest an idea for this project
title: ''
labels: enhancement
assignees: ''

---

## Description
Provide a clear and concise description of the problem to be solved.

## Solution
Add a clear and concise description of the proposed solution.

## Alternatives (optional)
If applicable, add a description of any alternative solutions or features you've considered.

## Related to (optional)
Directly reference any issues or PRs in this or other repositories that this is related to, and describe how they are related.
22 changes: 22 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
## Description of Changes:
One or more paragraphs describing the problem, solution, and required changes.

## Tests Conducted:
Explicitly state what tests were run on these changes, or if any are still pending (for README or other text-only changes, just put "None required". Make note of the compilers used, the platform/machine, and other relevant details as necessary. For more complicated changes, or those resulting in scientific changes, please be explicit!
**OR** Add any links to tests conducted. For example, "See ufs-community/ufs-weather-model/pull/<pr_number>"

## Dependencies:
Add any links to parent PRs (e.g. SCM and/or UFS PRs) or submodules (e.g. rte-rrtmgp). For example:
- NCAR/ccpp-framework/pull/<pr_number>
- NOAA-EMC/fv3atm/pull/<pr_number>
- ufs-community/ufs-weather-model/pull/<pr_number>

## Documentation:
Does this PR add new capabilities that need to be documented or require modifications to the existing documentation? If so, brief supporting material can be provided here. Contact the CODEOWNERS if your PR requires extensive updates to the documentation. See https://github.com/NCAR/ccpp-doc for Technical Documentation or https://dtcenter.org/community-code/common-community-physics-package-ccpp/documentation for the latest Scientific Documentation.

## Issue (optional):
If this PR is resolving or referencing one or more issues, in this repository or elewhere, list them here. For example, "Fixes issue mentioned in #123" or "Related to bug in https://github.com/NCAR/other_repository/pull/63"

## Contributors (optional):
If others have contributed to this work aside from the PR author, list them here

20 changes: 10 additions & 10 deletions physics/GFS_phys_time_vary.fv3.meta
Original file line number Diff line number Diff line change
Expand Up @@ -759,7 +759,7 @@
standard_name = surface_albedo_direct_visible_over_land
long_name = direct surface albedo visible band over land
units = frac
dimensions = (horizontal_loop_extent)
dimensions = (horizontal_dimension)
type = real
kind = kind_phys
intent = inout
Expand All @@ -768,7 +768,7 @@
standard_name = surface_albedo_direct_NIR_over_land
long_name = direct surface albedo NIR band over land
units = frac
dimensions = (horizontal_loop_extent)
dimensions = (horizontal_dimension)
type = real
kind = kind_phys
intent = inout
Expand All @@ -777,7 +777,7 @@
standard_name = surface_albedo_diffuse_visible_over_land
long_name = diffuse surface albedo visible band over land
units = frac
dimensions = (horizontal_loop_extent)
dimensions = (horizontal_dimension)
type = real
kind = kind_phys
intent = inout
Expand All @@ -786,7 +786,7 @@
standard_name = surface_albedo_diffuse_NIR_over_land
long_name = diffuse surface albedo NIR band over land
units = frac
dimensions = (horizontal_loop_extent)
dimensions = (horizontal_dimension)
type = real
kind = kind_phys
intent = inout
Expand All @@ -795,7 +795,7 @@
standard_name = surface_albedo_direct_visible_over_ice
long_name = direct surface albedo visible band over ice
units = frac
dimensions = (horizontal_loop_extent)
dimensions = (horizontal_dimension)
type = real
kind = kind_phys
intent = inout
Expand All @@ -804,7 +804,7 @@
standard_name = surface_albedo_direct_NIR_over_ice
long_name = direct surface albedo NIR band over ice
units = frac
dimensions = (horizontal_loop_extent)
dimensions = (horizontal_dimension)
type = real
kind = kind_phys
intent = inout
Expand All @@ -813,7 +813,7 @@
standard_name = surface_albedo_diffuse_visible_over_ice
long_name = diffuse surface albedo visible band over ice
units = frac
dimensions = (horizontal_loop_extent)
dimensions = (horizontal_dimension)
type = real
kind = kind_phys
intent = inout
Expand All @@ -822,7 +822,7 @@
standard_name = surface_albedo_diffuse_NIR_over_ice
long_name = diffuse surface albedo NIR band over ice
units = frac
dimensions = (horizontal_loop_extent)
dimensions = (horizontal_dimension)
type = real
kind = kind_phys
intent = inout
Expand All @@ -831,7 +831,7 @@
standard_name = surface_longwave_emissivity_over_land
long_name = surface lw emissivity in fraction over land
units = frac
dimensions = (horizontal_loop_extent)
dimensions = (horizontal_dimension)
type = real
kind = kind_phys
intent = inout
Expand All @@ -840,7 +840,7 @@
standard_name = surface_longwave_emissivity_over_ice
long_name = surface lw emissivity in fraction over ice
units = frac
dimensions = (horizontal_loop_extent)
dimensions = (horizontal_dimension)
type = real
kind = kind_phys
intent = inout
Expand Down
Loading

0 comments on commit 7468bf8

Please sign in to comment.