Limit suite names to 37 characters or less #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkavulich
added
the
ccpp_prebuild
mkavulich
requested review from
climbfuji,
grantfirl and
gold2718
as code owners
gold2718
approved these changes
Sep 27, 2022
climbfuji
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion on #337, this implements a hard cap on suite names of 37 characters for ccpp_prebuild.
User interface changes?: [ Yes ]
If a user attempts to run ccpp_prebuild with a suite name longer than 37 characters, prebuild will fail with an error message indicating the problem.
Fixes: Part of #337 (ccpp_prebuild only)
Testing:
test removed:
unit tests:
system tests:
manual testing: Ran ccpp_prebuild.py both stand-alone and for SCM, script ran successfully for existing suites, and failed as expected when a new long suite name was introduced. Will run more tests if requested.