Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update context config generator for telescopes #1067

Merged
merged 4 commits into from
Nov 18, 2024
Merged

Update context config generator for telescopes #1067

merged 4 commits into from
Nov 18, 2024

Conversation

jordanpadams
Copy link
Member

🗒️ Summary

Update context config generator for telescopes

⚙️ Test Data and/or Report

See test resources and new test case.

https://github.com/NASA-PDS/validate/blob/i1066/src/test/resources/features/3.6.x.feature#L76

♻️ Related Issues

Resolves #1066

Default to using `title` when `name` and/or `type` are not available. Specifically applicable to Telescope context products.

Resolves #1066
@jordanpadams jordanpadams requested a review from a team as a code owner November 18, 2024 22:51
Copy link
Member

@nutjob4life nutjob4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visual inspection passes. But the tests are failing?

WAIT … there was just a recent commit … okay, now the tests all pass:

Tests run: 259, Failures: 0, Errors: 0, Skipped: 23

Approved! 🎉

@jordanpadams jordanpadams merged commit b6f8538 into main Nov 18, 2024
3 checks passed
@jordanpadams jordanpadams deleted the i1066 branch November 18, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Telescopes missing from registry context products config
2 participants