chore!: Replace unmaintained tui with ratatui
#21285
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
DaughterOfMars
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
There was a problem hiding this comment.
Thank you so much for these changes!
Looks like there's a couple conflicts and formatting issues that need to be resolved, but overall the changes look good to me and once those conflicts are resolved and the tests are passing I'll more than happily land this.
Fixed! EDIT: Apparently it was not fixed, I must have mixed up branches. Should be fixed now. |
DaughterOfMars
force-pushed
the
replace-tui
branch
from
9718c18 to
8019dc9
Compare
DaughterOfMars
force-pushed
the
replace-tui
branch
from
8019dc9 to
06da8ec
Compare
DaughterOfMars
force-pushed
the
replace-tui
branch
from
06da8ec to
4bc6cf9
Compare
DaughterOfMars
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
|
We got some fixes to the deps list, so we'd need to rebase. @DaughterOfMars would it be ok for you to rebase, fix conflicts and push again? If not, I can do it. Just let me know! |
DaughterOfMars
force-pushed
the
replace-tui
branch
from
4bc6cf9 to
4562ea6
Compare
Done! |
Description
This PR replaces the unmaintained
tuiwithratatui, resolvingRUSTSEC-2023-0049. This is technically breaking to themove-bytecode-viewerpublic API, but this does not impact any internal crates and is unlikely to impact library users.Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.