Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL changes to enable pruning #20523

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Conversation

gegaowp
Copy link
Contributor

@gegaowp gegaowp commented Dec 5, 2024

Description

Test plan

cargo nextest run --no-capture sui-graphql-e2e-tests::tests run_test::stable/prune


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL: graphql changes to enable pruning, mainly around watermark
  • CLI:
  • Rust SDK:
  • REST API:

Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 1:52pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2024 1:52pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2024 1:52pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2024 1:52pm

Copy link
Contributor

@amnn amnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core change looks good, but it seems like there's a mismatch between one of the test's comments and the actual result it produces that we need to dig into, but accepting to unblock.

@gegaowp gegaowp temporarily deployed to sui-typescript-aws-kms-test-env December 6, 2024 13:51 — with GitHub Actions Inactive
@gegaowp gegaowp merged commit d7e3bb6 into MystenLabs:main Dec 6, 2024
48 checks passed
@gegaowp gegaowp deleted the prune-graphql branch December 6, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants