Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable upgrade compatibility checks for package upgrades #20342

Conversation

jordanjennings-mysten
Copy link
Contributor

@jordanjennings-mysten jordanjennings-mysten commented Nov 20, 2024

Description

Describe the changes or additions included in this PR.

Test plan

How did you test the new or updated feature?


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • JSON-RPC:
  • GraphQL:
  • CLI: Added --verify-compatibility flag to client upgrade command, which checks upgrade compatibility locally before publishing upgrades
  • Rust SDK:

Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 8:58am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2025 8:58am
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2025 8:58am
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2025 8:58am

@jordanjennings-mysten jordanjennings-mysten temporarily deployed to sui-typescript-aws-kms-test-env November 20, 2024 02:40 — with GitHub Actions Inactive
@jordanjennings-mysten jordanjennings-mysten temporarily deployed to sui-typescript-aws-kms-test-env November 25, 2024 20:21 — with GitHub Actions Inactive
@jordanjennings-mysten jordanjennings-mysten force-pushed the enable-upgrade-compatibility branch from 0ee2897 to 02e9f4b Compare January 7, 2025 23:51
@jordanjennings-mysten jordanjennings-mysten temporarily deployed to sui-typescript-aws-kms-test-env January 7, 2025 23:51 — with GitHub Actions Inactive
@jordanjennings-mysten jordanjennings-mysten force-pushed the enable-upgrade-compatibility branch from 02e9f4b to 20cd6d6 Compare January 15, 2025 07:20
@jordanjennings-mysten jordanjennings-mysten temporarily deployed to sui-typescript-aws-kms-test-env January 15, 2025 07:21 — with GitHub Actions Inactive
@jordanjennings-mysten jordanjennings-mysten temporarily deployed to sui-typescript-aws-kms-test-env January 15, 2025 07:38 — with GitHub Actions Inactive
@jordanjennings-mysten jordanjennings-mysten force-pushed the enable-upgrade-compatibility branch from a6cd56e to 2db3087 Compare January 15, 2025 07:53
@jordanjennings-mysten jordanjennings-mysten temporarily deployed to sui-typescript-aws-kms-test-env January 15, 2025 07:53 — with GitHub Actions Inactive
@jordanjennings-mysten jordanjennings-mysten force-pushed the enable-upgrade-compatibility branch from 2db3087 to 50e6eef Compare January 15, 2025 07:55
@jordanjennings-mysten jordanjennings-mysten temporarily deployed to sui-typescript-aws-kms-test-env January 15, 2025 07:55 — with GitHub Actions Inactive
@jordanjennings-mysten jordanjennings-mysten force-pushed the enable-upgrade-compatibility branch from 50e6eef to f3e7c36 Compare January 15, 2025 08:25
@jordanjennings-mysten jordanjennings-mysten temporarily deployed to sui-typescript-aws-kms-test-env January 15, 2025 08:25 — with GitHub Actions Inactive
Copy link
Contributor

@amnn amnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Excited to get this in people's hands 🚀

@jordanjennings-mysten jordanjennings-mysten marked this pull request as ready for review January 15, 2025 09:47
@jordanjennings-mysten jordanjennings-mysten temporarily deployed to sui-typescript-aws-kms-test-env January 15, 2025 09:47 — with GitHub Actions Inactive
@jordanjennings-mysten jordanjennings-mysten merged commit 1fb0a1d into MystenLabs:main Jan 21, 2025
82 of 84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants