-
Notifications
You must be signed in to change notification settings - Fork 11.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[move][move-2024] Coalesce locals during CFGIR #18483
Open
cgswords
wants to merge
5
commits into
main
Choose a base branch
from
cgswords/coalesce_vars
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
772f1d2
to
813f4b4
Compare
260ce54
to
39e7a37
Compare
tnowacki
reviewed
Jul 4, 2024
external-crates/move/crates/move-compiler/src/cfgir/translate.rs
Outdated
Show resolved
Hide resolved
external-crates/move/crates/move-compiler/src/cfgir/translate.rs
Outdated
Show resolved
Hide resolved
tnowacki
reviewed
Jul 10, 2024
external-crates/move/crates/move-compiler/src/cfgir/optimize/mod.rs
Outdated
Show resolved
Hide resolved
external-crates/move/crates/move-compiler/src/cfgir/optimize/mod.rs
Outdated
Show resolved
Hide resolved
external-crates/move/crates/move-compiler/src/cfgir/optimize/mod.rs
Outdated
Show resolved
Hide resolved
external-crates/move/crates/move-compiler/src/cfgir/optimize/mod.rs
Outdated
Show resolved
Hide resolved
external-crates/move/crates/move-compiler/src/cfgir/optimize/coalesce_locals.rs
Outdated
Show resolved
Hide resolved
external-crates/move/crates/move-compiler/src/cfgir/optimize/coalesce_locals.rs
Outdated
Show resolved
Hide resolved
external-crates/move/crates/move-compiler/src/cfgir/optimize/coalesce_locals.rs
Outdated
Show resolved
Hide resolved
external-crates/move/crates/move-compiler/src/cfgir/optimize/coalesce_locals.rs
Outdated
Show resolved
Hide resolved
7c65f59
to
3234f06
Compare
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This introduces local coalescing in the CFGIR, leading to reduced local generation during compilation.
Test plan
This needs so many more tests. Please help @tnowacki
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.