[Linter] Checks for equal operands to comparison, logical and bitwise, difference and division binary operators (==, >, etc., &&, ||, &, |, ^, - and /). #17115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
tx-tomcat
force-pushed
the
custom_rules/eq_op
branch
from
e910abd to
4712fa4
Compare
|
@tx-tomcat is attempting to deploy a commit to the Mysten Labs Team on Vercel. A member of the Team first needs to authorize it. |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
tx-tomcat
force-pushed
the
custom_rules/eq_op
branch
from
4712fa4 to
36b16e3
Compare
tx-tomcat
force-pushed
the
custom_rules/eq_op
branch
from
36484e3 to
437cc53
Compare
tnowacki
approved these changes
Nov 15, 2024
tnowacki
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tnowacki
reviewed
Dec 3, 2024
| )); | ||
| } | ||
|
|
||
| fn equal_operands(lhs: &Value_, op: BinOp_, rhs: &Value_) -> Option<&'static str> { |
There was a problem hiding this comment.
Now that I have it working, I am not sure how to feel about this
tnowacki
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements a new lint rule that detects binary operations with identical operands, which often indicate programming errors or redundant code. This lint helps maintain code quality by catching potentially problematic patterns early in development.
What it checks
The lint analyzes binary operations for the following operators when used with identical operands:
Comparison operators:
==,!=,>,>=,<,<=let x = 10; let _ = x == x; // ⚠️ Warning: Equal operands in comparisonLogical operators:
&&,||let _ = true && true; // ⚠️ Warning: Redundant logical operationBitwise operators:
&,|,^let x = 5; let _ = x & x; // ⚠️ Warning: Redundant bitwise operationArithmetic operators:
-,/let x = 10; let _ = x - x; // ⚠️ Warning: Subtraction with equal operandsTest plan
Added more use case including true positive, true negative, false positive, false negative case
Release notes