Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Smoother FreeFlightController, fixes #219 #229

Merged
merged 1 commit into from
Apr 12, 2018
Merged

Smoother FreeFlightController, fixes #219 #229

merged 1 commit into from
Apr 12, 2018

Conversation

caseyyee
Copy link
Contributor

@caseyyee caseyyee commented Apr 11, 2018

Same interaction, smoother action!

Fixes #219

@caseyyee caseyyee requested a review from cvan April 11, 2018 23:52
@caseyyee caseyyee changed the title Smoother FreeFlightController Smoother FreeFlightController, fixes #219 Apr 12, 2018
Copy link
Contributor

@cvan cvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested this several times, in and out of VR - it works superbly well! fantastic improvements 👍

@caseyyee
Copy link
Contributor Author

Thanks for the test! Woot!

@caseyyee caseyyee merged commit a79e5b0 into MozillaReality:master Apr 12, 2018
@delapuente
Copy link
Contributor

Oh, this is great! Very nice patch, @caseyyee. I totally forgot to return to the Input System when I got rid of the elevation controls! Elevation axis usually does not exist and the script will crash if you try to access an unexistent axis.

@cvan, since you approved the PR, just notice we are not shipping error-handling code and we are inconsistent with Unity’s C# style guide (i.e. capitalizing method names).

@caseyyee
Copy link
Contributor Author

caseyyee commented Apr 12, 2018

@delapuente never encountered issues with non-existent axis. Is it a WebGL only bug or something? Like a browser crash?

I'll review the Unity style guide since I'm not totally up to speed on best practice here. There is a LOT of inconsistency out there with C# styles and in example code posted by the community. Thanks for sharing that!

@cvan
Copy link
Contributor

cvan commented Apr 12, 2018

@cvan, since you approved the PR, just notice we are not shipping error-handling code and we are inconsistent with Unity’s C# style guide (i.e. capitalizing method names).

I know - I did comment about that in other PRs; @caseyyee agreed we'd handle it in #104

@cvan
Copy link
Contributor

cvan commented Apr 12, 2018

@delapuente never encountered issues with non-existent axis. Is it a WebGL only bug or something? Like a browser crash?

curious! can you show a screenshot or crash report? I've not seen this. will definitely file.

@cvan cvan added this to the v1.2.0 milestone Apr 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants