Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): 一定の条件でノート送信ボタンが意図しない見た目になる問題を修正 #884

Merged
merged 8 commits into from
Jan 12, 2025

Conversation

mattyatea
Copy link
Member

What

image

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@u1-liquid
Copy link
Member

u1-liquid commented Jan 12, 2025

これmedia queryのcssでdisplay: noneするだけで処理できるんじゃない?screenwidthをwatchする必要はなさそう

参考

@container (max-width: 500px) {
.headerRight {
font-size: .9em;
}
.headerRightButtonText {
display: none;
}

@u1-liquid
Copy link
Member

u1-liquid commented Jan 12, 2025

submitInnerにgapを設定するとmarginのためのclassは要らなくなりそう
あとちょっと下に既に350pxでの分岐があるのでそっちに統合しちゃっていいかも

@container (max-width: 350px) {

既存のmedia queryを使うように
Copy link
Member

@u1-liquid u1-liquid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • gapだけだと効かないのでflexにする
  • アイコンの位置がずれるのでspanで囲む
  • 1つの要素しかなければgapは何もしないので変えなくていい

mattyatea and others added 3 commits January 13, 2025 08:01
Co-authored-by: あわわわとーにゅ <17376330+u1-liquid@users.noreply.github.com>
Co-authored-by: あわわわとーにゅ <17376330+u1-liquid@users.noreply.github.com>
Co-authored-by: あわわわとーにゅ <17376330+u1-liquid@users.noreply.github.com>
@u1-liquid u1-liquid changed the title Fix: 一定の条件でノート送信ボタンが意図しない見た目になる問題を修正 fix(frontend): 一定の条件でノート送信ボタンが意図しない見た目になる問題を修正 Jan 12, 2025
@mattyatea
Copy link
Member Author

gapだけだと効かないのでflexにする
1つの要素しかなければgapは何もしないので変えなくていい

確かに...🥴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants