Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev to master (discord link) #1077

Merged
merged 4 commits into from
Feb 28, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
blank_issues_enabled: false
contact_links:
- name: Support
url: https://discord.gg/pw6Efvk
url: https://discord.gg/bVRQzgSbPq
about: GitHub issues are meant for tracking enhancements and bugs, not general support. Instead, search the Wiki, Playstrategy Forum, StackOverflow, or join our Discord.
20 changes: 8 additions & 12 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,31 +1,27 @@
# Contributing

## I want to contribute code to Lichess
## I want to contribute code to PlayStrategy

- [Set up your development environment](https://github.com/ornicar/lila/wiki/Lichess-Development-Onboarding).
- [Pick a GitHub issue to work on](https://github.com/ornicar/lila/issues). The [good first issue](https://github.com/ornicar/lila/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22) and [no scala](https://github.com/ornicar/lila/issues?q=is%3Aissue+is%3Aopen+label%3A%22no+scala%22) tags might be useful.
- Communicate with other devs on the #lichess IRC channel on freenode
or [Discord](https://discord.gg/hy5jqSs).
- Communicate with other devs on github or [Discord](https://discord.gg/bVRQzgSbPq).

## I want to report a bug or a problem about Lichess
## I want to report a bug or a problem about PlayStrategy

[**Make an issue**](https://github.com/ornicar/lila/issues/new). However, note that issues that provide little value compared to the required effort may be closed. Before creating an issue, make sure that:
[**Make an issue**](https://github.com/Mind-Sports-Games/lila/issues/new). However, note that issues that provide little value compared to the required effort may be closed. Before creating an issue, make sure that:

1. You list the steps to reproduce the problem to show that other users may experience it as well, if the issue is not self-descriptive.
2. Search to make sure it isn't a duplicate. [The advanced search syntax](https://help.github.com/articles/searching-issues/) may come in handy.
3. It is not a trivial problem or demand unrealistic dev time to fix.

Report mobile-only bugs to [Lichess mobile](https://github.com/veloce/lichobile/).
## I want to suggest a feature for PlayStrategy

## I want to suggest a feature for Lichess

Issue tickets on features that lack potential or effectiveness are not useful and may be closed. Discussions regarding whether a proposed new feature would be useful can be done on the [Lichess Feedback Forum](https://lichess.org/forum/lichess-feedback) to gauge feedback. The developers may also discuss the idea there, and if it is exemplary, a corresponding issue ticket will be made. **When you're ready, [make an issue ticket](https://github.com/ornicar/lila/issues/new)** and link relevant, constructive comments regarding it in your issue ticket (such as a detailed Reddit post; linking to an empty forum thread with only your own commentary adds no value). Make sure that the feature you propose:
Issue tickets on features that lack potential or effectiveness are not useful and may be closed. Discussions regarding whether a proposed new feature would be useful can be done on the [PlayStrategy Feedback Forum](https://playstrategy.org/forum/playstrategy-feedback) to gauge feedback. The developers may also discuss the idea there, and if it is exemplary, a corresponding issue ticket will be made. **When you're ready, [make an issue ticket](https://github.com/Mind-Sports-Games/lila/issues/new)** and link relevant, constructive comments regarding it in your issue ticket (such as a detailed Reddit post; linking to an empty forum thread with only your own commentary adds no value). Make sure that the feature you propose:

1. Is **effective in delivering a goal**. A feature that adds nothing new is purely fancy; please develop a userscript or userstyle for your personal use instead.
2. Doesn't rely on mundane assumptions. Non-technical people have the tendency to measure how difficult / easy a feature is to implement based on their unreliable instincts, and such assumptions wastes everyone's time. **Point out what needs to happen**, not what you think will happen.
3. Is **unique, if you're aiming to solve a problem**. Features that can easily be replaced by easier ideas have little value and may not have to be brought up to begin with.
4. Is **clear and concise**. If ambiguities exist, define them or propose options.

## I want to help translating Lichess
## I want to help translating PlayStrategy

Check out [Lichess on crowdin.com](https://crowdin.com/project/lichess).
Check out [PlayStrategy on crowdin.com](https://crowdin.com/project/playstrategy).
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ Proxy detection done with [IP2Proxy database](https://www.ip2location.com/databa

See [playstrategy.org/source](https://playstrategy.org/source) for a list of repositories.

Join us on discord for more info (coming soon...).
Join us on [discord](https://discord.gg/bVRQzgSbPq) for more info.
Use [GitHub issues](https://github.com/Mind-Sports-Games/lila/issues) for bug reports and feature requests.

## Installation
Expand Down
4 changes: 2 additions & 2 deletions app/views/appeal/tree.scala
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ object tree {
br,
"Please use ",
a(href := routes.Main.contact)("the contact page"),
//" or ",
//a(href := "")("our discord server"),
" or ",
a(href := "https://discord.gg/bVRQzgSbPq")("our discord server"),
" to contact us about other issues.",
br,
"You can also ",
Expand Down
2 changes: 1 addition & 1 deletion app/views/base/bits.scala
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ z-index: 99;
val connectLinks =
div(cls := "connect-links")(
a(href := "https://twitter.com/mindsportsolymp", targetBlank, noFollow)("Twitter"),
//a(href := "", targetBlank, noFollow)("Discord"),
a(href := "https://discord.gg/bVRQzgSbPq", targetBlank, noFollow)("Discord"),
a(href := "https://www.youtube.com/user/mindsportsolympiad", targetBlank, noFollow)("YouTube"),
a(href := "https://www.twitch.tv/mindsportsolympiad", targetBlank, noFollow)("Twitch")
)
Expand Down
4 changes: 2 additions & 2 deletions app/views/site/contact.scala
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,11 @@ object contact {
),
li(
a(href := "https://github.com/Mind-Sports-Games/lila/issues")(reportWebsiteIssue())
)
),
// li(
// a(href := "https://github.com/veloce/lichobile/issues")(reportMobileIssue())
// ),
//li(a(href := "https://discord.gg/hy5jqSs")(reportBugInDiscord()))
li(a(href := "https://discord.gg/bVRQzgSbPq")(reportBugInDiscord()))
),
p(howToReportBug())
)
Expand Down
6 changes: 3 additions & 3 deletions modules/blog/src/main/BlogApi.scala
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ final class BlogApi(
ref: Option[String]
): Fu[Option[Paginator[Document]]] =
api
.forms(collection)
.forms("everything")
.ref(ref | api.master.ref)
.orderings(s"[my.$collection.date desc]")
.pageSize(maxPerPage.value)
Expand All @@ -38,7 +38,7 @@ final class BlogApi(

def one(api: Api, ref: Option[String], id: String): Fu[Option[Document]] =
api
.forms(collection)
.forms("everything")
.query(s"""[[:d = at(document.id, "$id")]]""")
.ref(ref | api.master.ref)
.submit() map (_.results.headOption)
Expand All @@ -47,7 +47,7 @@ final class BlogApi(

def byYear(prismic: BlogApi.Context, year: Int): Fu[List[MiniPost]] = {
prismic.api
.forms(collection)
.forms("everything")
.ref(prismic.ref)
.query(s"[[date.year(my.$collection.date, $year)]]")
.orderings(s"[my.$collection.date desc]")
Expand Down
Loading