Skip to content

Rework CI Workflows #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 83 commits into from
Apr 22, 2023
Merged

Rework CI Workflows #384

merged 83 commits into from
Apr 22, 2023

Conversation

MikeSchulze
Copy link
Owner

@MikeSchulze MikeSchulze commented Apr 19, 2023 •
edited
Loading

Why

A user reported problems with UI tests.
The originally used 'barichello/godot-ci' image was run in headless mode and caused the UI tests to fail.

What

  • Complete rewrite of all WF, direct download and use of the Godot versions instead of the docker image.
  • Drastic runtime reduction by caching the Godot binaries.
  • Conversion of existing WF to reusable WF running over ci-pr and dev-pr.
  • reworked on GdUnitSceneRunnerInputEventTest to stablise flaky tests according to global_mouse position was not correct set

@MikeSchulze MikeSchulze added the help wanted Extra attention is needed label Apr 19, 2023
@MikeSchulze MikeSchulze self-assigned this Apr 19, 2023
@MikeSchulze MikeSchulze changed the title run user test on ci Rework Workflows Apr 21, 2023
@MikeSchulze MikeSchulze changed the title Rework Workflows Rework CI Workflows Apr 21, 2023
@MikeSchulze MikeSchulze added WIP Work in progress refactoring Mark to refactoring a implementation task A taks is a issue to define a task to needs be done and removed help wanted Extra attention is needed labels Apr 21, 2023
@MikeSchulze MikeSchulze removed the WIP Work in progress label Apr 22, 2023
@MikeSchulze MikeSchulze merged commit 4c775a7 into master Apr 22, 2023
@MikeSchulze MikeSchulze deleted the user-test branch April 22, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MikeSchulze MikeSchulze

Labels
refactoring Mark to refactoring a implementation task A taks is a issue to define a task to needs be done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MikeSchulze